[gn] Rework debug configurations

[gn] Rework debug configurations

This declares v8_enable_slow_dchecks and v8_optimized_debug
as gn args. It adds support for dcheck_always_on and
debugging with v8_optimized_debug = false.

BUG=chromium:474921
NOTRY=true

Committed: https://crrev.com/d311e1f1e54eec1e4d53502c05d81e5fc61f121d
Cr-Commit-Position: refs/heads/master@{#36789}

[Michael Achenbach, 2016-05-31 09:40:11]

Description was changed from

==========
[gn] Rework debug configurations

BUG=
==========

to

==========
[gn] Rework debug configurations

BUG=chromium:474921
NOTRY=true
==========

[Michael Achenbach, 2016-05-31 09:40:11]

machenbach@chromium.org changed reviewers:
+ jochen@chromium.org, vogelheim@chromium.org

[Michael Achenbach, 2016-05-31 09:41:57]

Description was changed from

==========
[gn] Rework debug configurations

BUG=chromium:474921
NOTRY=true
==========

to

==========
[gn] Rework debug configurations

This declares v8_enable_slow_dchecks and v8_optimized_debug
as gn args. It adds support for dcheck_always_on and
debugging with v8_optimized_debug = false.

BUG=chromium:474921
NOTRY=true
==========

[Michael Achenbach, 2016-05-31 09:42:05]

PTAL

[Michael Achenbach, 2016-05-31 11:14:39]

PTAL at patch 2

[jochen (gone - plz use gerrit), 2016-05-31 11:43:56]

lgtm

[vogelheim, 2016-05-31 14:04:54]

lgtm

https://codereview.chromium.org/2024833002/diff/40001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2024833002/diff/40001/BUILD.gn#newcode141
BUILD.gn:141: defines += [ "DEBUG" ]
readability nitpick, and not really sure about this:

It's a tad odd that DEBUG is sometimes defines here, and sometimes below (line
304). Can we move this check into the else branch of the if(is_debug) down
there? Then we'd have one big block that handles the DEBUG defines.

[Michael Achenbach, 2016-05-31 14:14:34]

https://codereview.chromium.org/2024833002/diff/40001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2024833002/diff/40001/BUILD.gn#newcode141
BUILD.gn:141: defines += [ "DEBUG" ]
On 2016/05/31 14:04:54, vogelheim wrote:
> readability nitpick, and not really sure about this:
> 
> It's a tad odd that DEBUG is sometimes defines here, and sometimes below (line
> 304). Can we move this check into the else branch of the if(is_debug) down
> there? Then we'd have one big block that handles the DEBUG defines.

Yea - can do. I wasn't really sure about what is a feauture and what's part of
toolchain. But I assume this is rather toolchain'ish stuff.

[Michael Achenbach, 2016-05-31 14:17:48]

On 2016/05/31 14:14:34, Michael Achenbach wrote:
> https://codereview.chromium.org/2024833002/diff/40001/BUILD.gn
> File BUILD.gn (right):
> 
> https://codereview.chromium.org/2024833002/diff/40001/BUILD.gn#newcode141
> BUILD.gn:141: defines += [ "DEBUG" ]
> On 2016/05/31 14:04:54, vogelheim wrote:
> > readability nitpick, and not really sure about this:
> > 
> > It's a tad odd that DEBUG is sometimes defines here, and sometimes below
(line
> > 304). Can we move this check into the else branch of the if(is_debug) down
> > there? Then we'd have one big block that handles the DEBUG defines.
> 
> Yea - can do. I wasn't really sure about what is a feauture and what's part of
> toolchain. But I assume this is rather toolchain'ish stuff.

Done

[Michael Achenbach, 2016-06-07 13:41:42]

The CQ bit was checked by machenbach@chromium.org

[Michael Achenbach, 2016-06-07 13:41:43]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/2024833002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-06-07 13:41:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2024833002/80001

[commit-bot: I haz the power, 2016-06-07 13:44:06]

Description was changed from

==========
[gn] Rework debug configurations

This declares v8_enable_slow_dchecks and v8_optimized_debug
as gn args. It adds support for dcheck_always_on and
debugging with v8_optimized_debug = false.

BUG=chromium:474921
NOTRY=true
==========

to

==========
[gn] Rework debug configurations

This declares v8_enable_slow_dchecks and v8_optimized_debug
as gn args. It adds support for dcheck_always_on and
debugging with v8_optimized_debug = false.

BUG=chromium:474921
NOTRY=true
==========

[commit-bot: I haz the power, 2016-06-07 13:44:07]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-07 13:44:48]

Description was changed from

==========
[gn] Rework debug configurations

This declares v8_enable_slow_dchecks and v8_optimized_debug
as gn args. It adds support for dcheck_always_on and
debugging with v8_optimized_debug = false.

BUG=chromium:474921
NOTRY=true
==========

to

==========
[gn] Rework debug configurations

This declares v8_enable_slow_dchecks and v8_optimized_debug
as gn args. It adds support for dcheck_always_on and
debugging with v8_optimized_debug = false.

BUG=chromium:474921
NOTRY=true

Committed: https://crrev.com/d311e1f1e54eec1e4d53502c05d81e5fc61f121d
Cr-Commit-Position: refs/heads/master@{#36789}
==========

[commit-bot: I haz the power, 2016-06-07 13:44:49]

Patchset 5 (id:??) landed as
https://crrev.com/d311e1f1e54eec1e4d53502c05d81e5fc61f121d
Cr-Commit-Position: refs/heads/master@{#36789}