[gn] Rework debug configurations

BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
 import("//build/config/arm.gni")
+import("//build/config/dcheck_always_on.gni")
 import("//build/config/mips.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 
 if (is_android) {
   import("//build/config/android/rules.gni")
 }
 
 import("gni/v8.gni")
 import("//build_overrides/v8.gni")
 
@@ skipping 23 matching lines @@
   # Sets -dENABLE_GDB_JIT_INTERFACE.
   v8_enable_gdbjit = false
 
   # Sets -dENABLE_HANDLE_ZAPPING.
   v8_enable_handle_zapping = true
 
   # Enable ECMAScript Internationalization API. Enabling this feature will
   # add a dependency on the ICU library.
   v8_enable_i18n_support = true
 
+  # Enable slow dchecks.
+  v8_enable_slow_dchecks = false
+
   # Interpreted regexp engine exists as platform-independent alternative
   # based where the regular expression is compiled to a bytecode.
   v8_interpreted_regexp = false
 
   # Sets -dOBJECT_PRINT.
   v8_object_print = false
 
+  # Turns on compiler optimizations in V8 in Debug build.
+  v8_optimized_debug = true
+
   # With post mortem support enabled, metadata is embedded into libv8 that
   # describes various parameters of the VM for use by debuggers. See
   # tools/gen-postmortem-metadata.py for details.
   v8_postmortem_support = false
 
   # Similar to vfp but on MIPS.
   v8_can_use_fpu_instructions = true
 
   # Similar to the ARM hard float ABI but on MIPS.
   v8_use_mips_abi_hardfloat = true
@@ skipping 56 matching lines @@
   if (v8_use_external_startup_data) {
     defines = [ "V8_USE_EXTERNAL_STARTUP_DATA" ]
   }
 }
 
 config("features") {
   visibility = [ ":*" ]  # Only targets in this file can depend on this.
 
   defines = []
 
+  if (!is_debug && dcheck_always_on) {
+    defines += [ "DEBUG" ]

[vogelheim, 2016/05/31 14:04:54]

readability nitpick, and not really sure about this:

It's a tad odd that DEBUG is sometimes defines here, and sometimes below (line
304). Can we move this check into the else branch of the if(is_debug) down
there? Then we'd have one big block that handles the DEBUG defines.

[Michael Achenbach, 2016/05/31 14:14:34]

Yea - can do. I wasn't really sure about what is a feauture and what's part of
toolchain. But I assume this is rather toolchain'ish stuff.

+  }
   if (v8_enable_disassembler) {
     defines += [ "ENABLE_DISASSEMBLER" ]
   }
   if (v8_enable_gdbjit) {
     defines += [ "ENABLE_GDB_JIT_INTERFACE" ]
   }
   if (v8_object_print) {
     defines += [ "OBJECT_PRINT" ]
   }
   if (v8_enable_verify_heap) {
@@ skipping 144 matching lines @@
   if (is_debug) {
     # TODO(jochen): Add support for different debug optimization levels.
     defines += [
       "ENABLE_DISASSEMBLER",
       "V8_ENABLE_CHECKS",
       "OBJECT_PRINT",
       "VERIFY_HEAP",
       "DEBUG",
       "TRACE_MAPS",
     ]
-    if (!v8_optimized_debug) {
+    if (v8_enable_slow_dchecks) {
       defines += [ "ENABLE_SLOW_DCHECKS" ]
     }
   }
 }
 
 ###############################################################################
 # Templates
 #
 
 template("v8_source_set") {
   source_set(target_name) {
     forward_variables_from(invoker, "*", [ "configs" ])
     configs += invoker.configs
     configs -= [ "//build/config/compiler:chromium_code" ]
     configs += [ "//build/config/compiler:no_chromium_code" ]
     configs += [
       ":features",
       ":toolchain",
     ]
 
-    if (!is_debug || v8_optimized_debug) {
+    # TODO(machenbach): This config doesn't affect executables and components.
+    # It should be moved to a common place.
+    if (is_debug && !v8_optimized_debug) {
+      configs -= [ "//build/config/compiler:default_optimization" ]
+      configs += [ "//build/config/compiler:no_optimize" ]
+    } else {
       configs -= [ "//build/config/compiler:default_optimization" ]
       configs += [ "//build/config/compiler:optimize_max" ]
     }
   }
 }
 
 ###############################################################################
 # Actions
 #
 
@@ skipping 1902 matching lines @@
   sources = [
     "test/fuzzer/wasm-asmjs.cc",
   ]
 
   deps = [
     ":fuzzer_support",
   ]
 
   configs = [ ":internal_config" ]
 }