Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 202483006: Add a timeout property to NavigateAction. (Closed)

Created:
6 years, 9 months ago by bolian
Modified:
6 years, 9 months ago
Reviewers:
dtu
CC:
chromium-reviews, telemetry+watch_chromium.org, tonyg, bengr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add a timeout attr to NavigateAction. BUG=320748 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257922

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M tools/telemetry/telemetry/page/actions/navigate.py View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
bolian
Hi Dave, In some of my tests (https://codereview.chromium.org/191383003/), navigation timeout is expected and a much ...
6 years, 9 months ago (2014-03-18 00:53:15 UTC) #1
dtu
I think Nat is heading the change in this area. But I don't think this ...
6 years, 9 months ago (2014-03-18 23:51:18 UTC) #2
bolian
The CQ bit was checked by bolian@chromium.org
6 years, 9 months ago (2014-03-18 23:53:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bolian@chromium.org/202483006/1
6 years, 9 months ago (2014-03-18 23:57:07 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 01:05:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_compile_dbg
6 years, 9 months ago (2014-03-19 01:05:13 UTC) #6
bolian
The CQ bit was checked by bolian@chromium.org
6 years, 9 months ago (2014-03-19 01:25:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bolian@chromium.org/202483006/1
6 years, 9 months ago (2014-03-19 01:26:47 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 11:14:19 UTC) #9
Message was sent while issue was closed.
Change committed as 257922

Powered by Google App Engine
This is Rietveld 408576698