Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: tools/telemetry/telemetry/page/actions/navigate.py

Issue 202483006: Add a timeout property to NavigateAction. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/actions/navigate.py
diff --git a/tools/telemetry/telemetry/page/actions/navigate.py b/tools/telemetry/telemetry/page/actions/navigate.py
index 237278760982101a8bb82eb8b7fa3c1ef3c176b6..0762c7e9080447fa0ca768d97b7917b9716bb189 100644
--- a/tools/telemetry/telemetry/page/actions/navigate.py
+++ b/tools/telemetry/telemetry/page/actions/navigate.py
@@ -14,5 +14,10 @@ class NavigateAction(page_action.PageAction):
else:
target_side_url = page.url
- tab.Navigate(target_side_url, page.script_to_evaluate_on_commit)
+ if hasattr(self, 'timeout_seconds') and self.timeout_seconds:
+ tab.Navigate(target_side_url,
+ page.script_to_evaluate_on_commit,
+ self.timeout_seconds)
+ else:
+ tab.Navigate(target_side_url, page.script_to_evaluate_on_commit)
tab.WaitForDocumentReadyStateToBeInteractiveOrBetter()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698