Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2024763002: Re-add backspace-goes-back as a default disabled finch trial. (Closed)

Created:
4 years, 6 months ago by Matt Giuca
Modified:
4 years, 6 months ago
Reviewers:
Peter Kasting, ojan
CC:
chrome-apps-syd-reviews_chromium.org, chromium-reviews, derat+watch_chromium.org, Peter Kasting, tfarina, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Re-add backspace-goes-back as a default disabled finch trial. This is just so that we have a kill switch in case this makes it to stable and there is then unexpected outcry. BUG=610039 Review-Url: https://codereview.chromium.org/1992003002 Cr-Commit-Position: refs/heads/master@{#395141} (cherry picked from commit c7e4899df2f7e590de44237b4a2fdfd978ec70df) TBR=ojan@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/021778e93de332bc674d30c81edf813f86a0ae26

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -2 lines) Patch
M chrome/app/chrome_command_ids.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/app_mode/app_mode_utils.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/global_keyboard_shortcuts_mac.mm View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/global_keyboard_shortcuts_mac_unittest.mm View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 4 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/accelerator_table.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/constrained_window_views_browsertest.cc View 1 chunk +47 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
Matt Giuca
Committed patchset #1 (id:1) manually as 021778e93de332bc674d30c81edf813f86a0ae26 (presubmit successful).
4 years, 6 months ago (2016-05-31 02:42:03 UTC) #4
Peter Kasting
LGTM
4 years, 6 months ago (2016-05-31 04:07:29 UTC) #6
ojan
Thanks for doing this! Was a pleasant surprise to wake up this morning and find ...
4 years, 6 months ago (2016-05-31 17:24:10 UTC) #7
Matt Giuca
4 years, 6 months ago (2016-06-01 00:49:26 UTC) #8
Message was sent while issue was closed.
On 2016/05/31 17:24:10, ojan wrote:
> Thanks for doing this! Was a pleasant surprise to wake up this morning and
find
> I had less work to do than expected. :)

np. My change was blocked on it, so :)

Powered by Google App Engine
This is Rietveld 408576698