Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 2023763004: Added notification when user presses backspace to use new shortcut. (Closed)

Created:
4 years, 6 months ago by Matt Giuca
Modified:
4 years, 6 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org, Peter Kasting
Base URL:
https://chromium.googlesource.com/chromium/src.git@drover-ojan-readd-backspace
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Added notification when user presses backspace to use new shortcut. This adds a new type of notification bubble (based on the "Press Esc to exit fullscreen" notification) that teaches users the new shortcuts for Back and Forward when they press Back or Shift+Back. Only implemented on Views systems (Windows, Linux, Chrome OS). BUG=610039 Review-Url: https://codereview.chromium.org/1983803002 Cr-Commit-Position: refs/heads/master@{#396138} (cherry picked from commit 7f3ddc6b70a09c7ae3bcd0d45007e415857fd09c) Committed: https://chromium.googlesource.com/chromium/src/+/0cf3ec2939b1c4ec43b4aa7570ecb80ac1fbb1fb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+297 lines, -56 lines) Patch
M chrome/app/chrome_command_ids.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_window.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 3 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 3 chunks +18 lines, -1 line 0 comments Download
A chrome/browser/ui/views/new_back_shortcut_bubble.h View 1 chunk +66 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/new_back_shortcut_bubble.cc View 1 chunk +118 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/subtle_notification_view.cc View 3 chunks +64 lines, -53 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/base/test_browser_window.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/base/test_browser_window.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 5 (3 generated)
Matt Giuca
Committed patchset #1 (id:1) manually as 0cf3ec2939b1c4ec43b4aa7570ecb80ac1fbb1fb.
4 years, 6 months ago (2016-05-31 02:46:40 UTC) #3
Peter Kasting
4 years, 6 months ago (2016-05-31 04:07:34 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698