Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2128)

Unified Diff: chrome/browser/safe_browsing/permission_reporter.cc

Issue 2024753002: Add permission reporter skeleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@protocol-buffer-for-permission-reports
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/permission_reporter.cc
diff --git a/chrome/browser/safe_browsing/permission_reporter.cc b/chrome/browser/safe_browsing/permission_reporter.cc
new file mode 100644
index 0000000000000000000000000000000000000000..5e0dec6dd4797d335359b885900babb6c02f9436
--- /dev/null
+++ b/chrome/browser/safe_browsing/permission_reporter.cc
@@ -0,0 +1,36 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/safe_browsing/permission_reporter.h"
+#include "chrome/common/safe_browsing/permission_report.pb.h"
+
+using content::PermissionType;
+
+namespace safe_browsing {
+
+namespace {
+// URL to upload permission action reports.
+static const char kPermissionActionReportingUploadUrl[] =
+ "http://safebrowsing.googleusercontent.com/safebrowsing/clientreport/"
+ "permission-action";
+} // namespace
+
+PermissionReporter::PermissionReporter(net::URLRequestContext* request_context)
+ : upload_url_(GURL(kPermissionActionReportingUploadUrl)) {}
raymes 2016/06/01 06:45:44 nit: I think you should be able to omit the "GURL(
stefanocs 2016/06/01 07:25:02 Done.
+
+PermissionReporter::~PermissionReporter() {}
+
+void PermissionReporter::SendReport(const std::string& serialized_report) {
+ // TODO(stefanocs): Implement SendReport function.
+}
+
raymes 2016/06/01 06:45:44 nit: // static
stefanocs 2016/06/01 07:25:02 I think we can't mark this as static here.
kcarattini 2016/06/01 12:25:49 What he means is to put a comment above the functi
stefanocs 2016/06/02 00:24:32 Done.
+bool PermissionReporter::BuildReport(const GURL& origin,
+ PermissionType permission,
+ PermissionAction action,
+ std::string* output) {
+ // TODO(stefanocs): Implement BuildReport function.
+ return true;
+}
+
+} // namespace safe_browsing

Powered by Google App Engine
This is Rietveld 408576698