Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Side by Side Diff: chrome/browser/safe_browsing/permission_reporter.cc

Issue 2024753002: Add permission reporter skeleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@protocol-buffer-for-permission-reports
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/safe_browsing/permission_reporter.h"
6 #include "chrome/common/safe_browsing/permission_report.pb.h"
7
8 using content::PermissionType;
9
10 namespace safe_browsing {
11
12 namespace {
13 // URL to upload permission action reports.
14 static const char kPermissionActionReportingUploadUrl[] =
15 "http://safebrowsing.googleusercontent.com/safebrowsing/clientreport/"
16 "permission-action";
17 } // namespace
18
19 PermissionReporter::PermissionReporter(net::URLRequestContext* request_context)
20 : upload_url_(GURL(kPermissionActionReportingUploadUrl)) {}
raymes 2016/06/01 06:45:44 nit: I think you should be able to omit the "GURL(
stefanocs 2016/06/01 07:25:02 Done.
21
22 PermissionReporter::~PermissionReporter() {}
23
24 void PermissionReporter::SendReport(const std::string& serialized_report) {
25 // TODO(stefanocs): Implement SendReport function.
26 }
27
raymes 2016/06/01 06:45:44 nit: // static
stefanocs 2016/06/01 07:25:02 I think we can't mark this as static here.
kcarattini 2016/06/01 12:25:49 What he means is to put a comment above the functi
stefanocs 2016/06/02 00:24:32 Done.
28 bool PermissionReporter::BuildReport(const GURL& origin,
29 PermissionType permission,
30 PermissionAction action,
31 std::string* output) {
32 // TODO(stefanocs): Implement BuildReport function.
33 return true;
34 }
35
36 } // namespace safe_browsing
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698