Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2024703002: Remove unnecessary "mac" meta data tag from Android Manifest (Closed)

Created:
4 years, 6 months ago by pkotwicz
Modified:
4 years, 6 months ago
Reviewers:
Xi Han
CC:
chromium-reviews, hartmanng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary "mac" meta data tag from Android Manifest BUG=None Committed: https://crrev.com/8ca0e460ebc48bc61ad85fce28bb8136ef9da6b8 Cr-Commit-Position: refs/heads/master@{#396764}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M chrome/android/webapk/shell_apk/AndroidManifest.xml View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/webapk/shell_apk/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java View 1 4 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
pkotwicz
Xi can you please take a look?
4 years, 6 months ago (2016-05-30 18:51:16 UTC) #2
Xi Han
I think this CL is to upstream. Please update MainActivity as well:) Thanks for the ...
4 years, 6 months ago (2016-05-30 19:33:24 UTC) #3
pkotwicz
Done! Thank you for reminding me Xi!
4 years, 6 months ago (2016-05-30 19:38:47 UTC) #5
Xi Han
lgtm, please update the bug # in the CL description.
4 years, 6 months ago (2016-05-30 20:17:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024703002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024703002/40001
4 years, 6 months ago (2016-05-31 00:01:49 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 6 months ago (2016-05-31 01:23:08 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 01:24:57 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/8ca0e460ebc48bc61ad85fce28bb8136ef9da6b8
Cr-Commit-Position: refs/heads/master@{#396764}

Powered by Google App Engine
This is Rietveld 408576698