chrome/android/webapk/shell_apk/BUILD.gn - Issue 2024703002: Remove unnecessary "mac" meta data tag from Android Manifest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/webapk/shell_apk/BUILD.gn

Issue 2024703002: Remove unnecessary "mac" meta data tag from Android Manifest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/webapk/shell_apk/AndroidManifest.xml ('k') | chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/webapk/shell_apk/BUILD.gn

diff --git a/chrome/android/webapk/shell_apk/BUILD.gn b/chrome/android/webapk/shell_apk/BUILD.gn

index aee57adc686b27152e9f138d27cb47dd5907c2b1..3c9f4b26b77a3517dfa843cdc9f9dd5e102cfd12 100644

--- a/chrome/android/webapk/shell_apk/BUILD.gn

+++ b/chrome/android/webapk/shell_apk/BUILD.gn

@@ -15,9 +15,6 @@ declare_args() {

# The browser that the WebAPK will be bound to.

webapk_runtime_host = "com.google.android.apps.chrome"

- # The message authentication code from Chrome for identity verification.

- webapk_mac = "template"

# The scope of the urls that the WebAPK can navigate to.

webapk_scope_url = "https://www.template.com"

@@ -38,7 +35,6 @@ jinja_template("shell_apk_manifest") {

"manifest_package=$shell_apk_manifest_package",

"host_url=$webapk_start_url",

"runtime_host=$webapk_runtime_host",

- "mac=$webapk_mac",

"scope_url=$webapk_scope_url",

"scope_url_host=$webapk_scope_url_host",

]