Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 2024683002: Remove debug instrumentation for crbug.com/359406. (Closed)

Created:
4 years, 6 months ago by Alexei Svitkine (slow)
Modified:
4 years, 6 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove debug instrumentation for crbug.com/359406. There are no more signs of the crash. This CL reverts the code to its original state to verify that the crash doesn't re-appear. If it doesn't re-appear, we can conclude that the issue is fixed, although it still bothers me that we don't know why. BUG=359406 Committed: https://crrev.com/a6f3f2dca40126f21bd937e3106eef97aba10fde Cr-Commit-Position: refs/heads/master@{#396753}

Patch Set 1 #

Patch Set 2 : include hygiene #

Patch Set 3 : missing header #

Patch Set 4 : update render_messages macro #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -182 lines) Patch
M base/metrics/field_trial.h View 1 chunk +0 lines, -14 lines 0 comments Download
M base/metrics/field_trial.cc View 1 10 chunks +2 lines, -101 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/metrics/field_trial_synchronizer.cc View 1 2 chunks +1 line, -13 lines 0 comments Download
M chrome/common/render_messages.h View 1 2 3 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/renderer/chrome_render_thread_observer.h View 1 2 2 chunks +1 line, -4 lines 0 comments Download
M chrome/renderer/chrome_render_thread_observer.cc View 1 2 chunks +1 line, -42 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Alexei Svitkine (slow)
4 years, 6 months ago (2016-05-30 17:46:38 UTC) #2
rkaplow
lgtm
4 years, 6 months ago (2016-05-30 17:50:10 UTC) #3
Alexei Svitkine (slow)
+thestig for chrome/ OWNERS +wfh render_messages.h OWNERS
4 years, 6 months ago (2016-05-30 17:54:07 UTC) #6
Lei Zhang
lgtm
4 years, 6 months ago (2016-05-30 20:25:44 UTC) #7
Will Harris
On 2016/05/30 20:25:44, Lei Zhang wrote: > lgtm lgtm for IPC messages.
4 years, 6 months ago (2016-05-30 20:29:06 UTC) #8
Will Harris
On 2016/05/30 20:25:44, Lei Zhang wrote: > lgtm lgtm for IPC messages.
4 years, 6 months ago (2016-05-30 20:29:10 UTC) #9
Will Harris
On 2016/05/30 20:25:44, Lei Zhang wrote: > lgtm lgtm for IPC messages.
4 years, 6 months ago (2016-05-30 20:29:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024683002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024683002/60001
4 years, 6 months ago (2016-05-30 20:29:31 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-05-30 22:01:18 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-05-30 22:02:36 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a6f3f2dca40126f21bd937e3106eef97aba10fde
Cr-Commit-Position: refs/heads/master@{#396753}

Powered by Google App Engine
This is Rietveld 408576698