Remove debug instrumentation for crbug.com/359406.

base/metrics/field_trial.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/metrics/field_trial.h"
 
 #include <algorithm>
 
 #include "base/build_time.h"
-#include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/rand_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 
 namespace base {
 
 namespace {
@@ skipping 79 matching lines @@
         trials_string_piece.substr(next_item, name_end - next_item);
     entry.group_name =
         trials_string_piece.substr(name_end + 1, group_name_end - name_end - 1);
     next_item = group_name_end + 1;
 
     entries->push_back(entry);
   }
   return true;
 }
 
-void CheckTrialGroup(const std::string& trial_name,
-                     const std::string& trial_group,
-                     std::map<std::string, std::string>* seen_states) {
-  if (ContainsKey(*seen_states, trial_name)) {
-    CHECK_EQ((*seen_states)[trial_name], trial_group) << trial_name;
-  } else {
-    (*seen_states)[trial_name] = trial_group;
-  }
-}
-
-// A second copy of FieldTrialList::seen_states_ that is meant to outlive the
-// FieldTrialList object to determine if the inconsistency happens because there
-// might be multiple FieldTrialList objects.
-// TODO(asvitkine): Remove when crbug.com/359406 is resolved.
-base::LazyInstance<std::map<std::string, std::string>>::Leaky g_seen_states =
-    LAZY_INSTANCE_INITIALIZER;
-
-// A debug token generated during FieldTrialList construction. Used to diagnose
-// crbug.com/359406.
-// TODO(asvitkine): Remove when crbug.com/359406 is resolved.
-int32_t g_debug_token = -1;
-
-// Whether to append the debug token to the child process --force-fieldtrials
-// command line. Used to diagnose crbug.com/359406.
-// TODO(asvitkine): Remove when crbug.com/359406 is resolved.
-bool g_append_debug_token_to_trial_string = false;
-
-// Tracks whether |g_seen_states| is used. Defaults to false, because unit tests
-// will create multiple FieldTrialList instances. Also controls whether
-// |g_debug_token| is included in the field trial state string.
-bool g_use_global_check_states = false;
-
 }  // namespace
 
 // statics
 const int FieldTrial::kNotFinalized = -1;
 const int FieldTrial::kDefaultGroupNumber = 0;
 bool FieldTrial::enable_benchmarking_ = false;
 
 int FieldTrialList::kNoExpirationYear = 0;
 
 //------------------------------------------------------------------------------
@@ skipping 83 matching lines @@
   if (forced_)
     return;
 
   // And we must finalize the group choice before we mark ourselves as forced.
   FinalizeGroupChoice();
   forced_ = true;
 }
 
 // static
 void FieldTrial::EnableBenchmarking() {
-  // TODO(asvitkine): Change this back to 0u after the trial in FieldTrialList
-  // constructor is removed.
-  DCHECK_EQ(1u, FieldTrialList::GetFieldTrialCount());
+  DCHECK_EQ(0u, FieldTrialList::GetFieldTrialCount());
   enable_benchmarking_ = true;
 }
 
 // static
 FieldTrial* FieldTrial::CreateSimulatedFieldTrial(
     const std::string& trial_name,
     Probability total_probability,
     const std::string& default_group_name,
     double entropy_value) {
   return new FieldTrial(trial_name, total_probability, default_group_name,
@@ skipping 11 matching lines @@
       accumulated_group_probability_(0),
       next_group_number_(kDefaultGroupNumber + 1),
       group_(kNotFinalized),
       enable_field_trial_(true),
       forced_(false),
       group_reported_(false),
       trial_registered_(false) {
   DCHECK_GT(total_probability, 0);
   DCHECK(!trial_name_.empty());
   DCHECK(!default_group_name_.empty());
-
-  if (g_debug_token == -1)
-    g_debug_token = RandInt(1, INT32_MAX);
 }
 
 FieldTrial::~FieldTrial() {}
 
 void FieldTrial::SetTrialRegistered() {
   DCHECK_EQ(kNotFinalized, group_);
   DCHECK(!trial_registered_);
   trial_registered_ = true;
 }
 
@@ skipping 45 matching lines @@
 bool FieldTrialList::used_without_global_ = false;
 
 FieldTrialList::Observer::~Observer() {
 }
 
 FieldTrialList::FieldTrialList(
     const FieldTrial::EntropyProvider* entropy_provider)
     : entropy_provider_(entropy_provider),
       observer_list_(new ObserverListThreadSafe<FieldTrialList::Observer>(
           ObserverListBase<FieldTrialList::Observer>::NOTIFY_EXISTING_ONLY)) {
-  // TODO(asvitkine): Turn into a DCHECK after http://crbug.com/359406 is fixed.
-  CHECK(!global_);
+  DCHECK(!global_);
   DCHECK(!used_without_global_);
   global_ = this;
 
   Time two_years_from_build_time = GetBuildTime() + TimeDelta::FromDays(730);
   Time::Exploded exploded;
   two_years_from_build_time.LocalExplode(&exploded);
   kNoExpirationYear = exploded.year;
-
-  // Run a 50/50 experiment that enables |g_use_global_check_states| only for
-  // half the users, to investigate if this instrumentation is causing the
-  // crashes to disappear for http://crbug.com/359406. Done here instead of a
-  // server-side trial because this needs to be done early during FieldTrialList
-  // initialization.
-  //
-  // Note: |g_use_global_check_states| is set via EnableGlobalStateChecks()
-  // prior to the FieldTrialList being created. We only want to do the trial
-  // check once the first time FieldTrialList is created, so use a static
-  // |first_time| variable to track this.
-  //
-  // TODO(asvitkine): Remove after http://crbug.com/359406 is fixed.
-  static bool first_time = true;
-  if (first_time && g_use_global_check_states) {
-    first_time = false;
-    base::FieldTrial* trial =
-        FactoryGetFieldTrial("UMA_CheckStates", 100, "NoChecks",
-                             kNoExpirationYear, 1, 1,
-                             FieldTrial::SESSION_RANDOMIZED, nullptr);
-    trial->AppendGroup("Checks", 50);
-    if (trial->group_name() == "NoChecks")
-      g_use_global_check_states = false;
-  }
 }
 
 FieldTrialList::~FieldTrialList() {
   AutoLock auto_lock(lock_);
   while (!registered_.empty()) {
     RegistrationMap::iterator it = registered_.begin();
     it->second->Release();
     registered_.erase(it->first);
   }
   DCHECK_EQ(this, global_);
   global_ = NULL;
 }
 
 // static
-void FieldTrialList::EnableGlobalStateChecks() {
-  CHECK(!g_use_global_check_states);
-  g_use_global_check_states = true;
-  g_append_debug_token_to_trial_string = true;
-}
-
-// static
-int32_t FieldTrialList::GetDebugToken() {
-  return g_debug_token;
-}
-
-// static
 FieldTrial* FieldTrialList::FactoryGetFieldTrial(
     const std::string& trial_name,
     FieldTrial::Probability total_probability,
     const std::string& default_group_name,
     const int year,
     const int month,
     const int day_of_month,
     FieldTrial::RandomizationType randomization_type,
     int* default_group_number) {
   return FactoryGetFieldTrialWithRandomizationSeed(
@@ skipping 111 matching lines @@
        it != active_groups.end(); ++it) {
     DCHECK_EQ(std::string::npos,
               it->trial_name.find(kPersistentStringSeparator));
     DCHECK_EQ(std::string::npos,
               it->group_name.find(kPersistentStringSeparator));
     output->append(it->trial_name);
     output->append(1, kPersistentStringSeparator);
     output->append(it->group_name);
     output->append(1, kPersistentStringSeparator);
   }
-  if (g_append_debug_token_to_trial_string) {
-    output->append("DebugToken");
-    output->append(1, kPersistentStringSeparator);
-    output->append(IntToString(g_debug_token));
-    output->append(1, kPersistentStringSeparator);
-  }
 }
 
 // static
 void FieldTrialList::AllStatesToString(std::string* output) {
   if (!global_)
     return;
   AutoLock auto_lock(global_->lock_);
 
   for (const auto& registered : global_->registered_) {
     FieldTrial::State trial;
     if (!registered.second->GetState(&trial))
       continue;
     DCHECK_EQ(std::string::npos,
               trial.trial_name.find(kPersistentStringSeparator));
     DCHECK_EQ(std::string::npos,
               trial.group_name.find(kPersistentStringSeparator));
     if (trial.activated)
       output->append(1, kActivationMarker);
     trial.trial_name.AppendToString(output);
     output->append(1, kPersistentStringSeparator);
     trial.group_name.AppendToString(output);
     output->append(1, kPersistentStringSeparator);
-
-    // TODO(asvitkine): Remove these when http://crbug.com/359406 is fixed.
-    CheckTrialGroup(trial.trial_name.as_string(), trial.group_name.as_string(),
-                    &global_->seen_states_);
-    if (g_use_global_check_states) {
-      CheckTrialGroup(trial.trial_name.as_string(),
-                      trial.group_name.as_string(), &g_seen_states.Get());
-    }
   }
 }
 
 // static
 void FieldTrialList::GetActiveFieldTrialGroups(
     FieldTrial::ActiveGroups* active_groups) {
   DCHECK(active_groups->empty());
   if (!global_)
     return;
   AutoLock auto_lock(global_->lock_);
@@ skipping 104 matching lines @@
   {
     AutoLock auto_lock(global_->lock_);
     if (field_trial->group_reported_)
       return;
     field_trial->group_reported_ = true;
   }
 
   if (!field_trial->enable_field_trial_)
     return;
 
-  // TODO(asvitkine): Remove this block when http://crbug.com/359406 is fixed.
-  {
-    AutoLock auto_lock(global_->lock_);
-    CheckTrialGroup(field_trial->trial_name(),
-                    field_trial->group_name_internal(), &global_->seen_states_);
-    if (g_use_global_check_states) {
-      CheckTrialGroup(field_trial->trial_name(),
-                      field_trial->group_name_internal(), &g_seen_states.Get());
-    }
-  }
   global_->observer_list_->Notify(
       FROM_HERE, &FieldTrialList::Observer::OnFieldTrialGroupFinalized,
       field_trial->trial_name(), field_trial->group_name_internal());
 }
 
 // static
 size_t FieldTrialList::GetFieldTrialCount() {
   if (!global_)
     return 0;
   AutoLock auto_lock(global_->lock_);
@@ skipping 25 matching lines @@
     return;
   }
   AutoLock auto_lock(global_->lock_);
   CHECK(!global_->PreLockedFind(trial->trial_name())) << trial->trial_name();
   trial->AddRef();
   trial->SetTrialRegistered();
   global_->registered_[trial->trial_name()] = trial;
 }
 
 }  // namespace base