Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2024673002:
[iOS] Always pass "-ObjC" when linking iOS executables. (Closed)
|
Created:
4 years, 6 months ago by sdefresne Modified:
4 years, 6 months ago Reviewers:
noyau (Ping after 24h) CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@{1} Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[iOS] Always pass "-ObjC" when linking iOS executables.
Chrome on iOS needs to use "-ObjC" to link all symbols from static
libraries that define at least one Objective-C category or class.
Add it to the ios_app_bundle template so that it is used by all
executables.
BUG=459705
Committed: https://crrev.com/ca860463e4432111af876304ff8ffea60c01ca9c
Cr-Commit-Position: refs/heads/master@{#397087}
Patch Set 1 #Patch Set 2 : Rebase on top of https://codereview.chromium.org/2019403002 #
Depends on Patchset: Messages
Total messages: 19 (10 generated)
sdefresne@chromium.org changed reviewers: + noyau@chromium.org
Please take a look and send to CQ if LGTY.
The CQ bit was checked by noyau@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024673002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
The CQ bit was checked by sdefresne@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from noyau@chromium.org Link to the patchset: https://codereview.chromium.org/2024673002/#ps20001 (title: "Rebase on top of https://codereview.chromium.org/2019403002")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024673002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024673002/20001
The CQ bit was unchecked by sdefresne@chromium.org
Description was changed from ========== [iOS] Always pass "-fObjC" when linking iOS executables. Chrome on iOS needs to use "-fObjC" to link all symbols from static libraries that define at least one Objective-C category or class. Add it to the ios_app_bundle template so that it is used by all executables. BUG=459705 ========== to ========== [iOS] Always pass "-ObjC" when linking iOS executables. Chrome on iOS needs to use "-ObjC" to link all symbols from static libraries that define at least one Objective-C category or class. Add it to the ios_app_bundle template so that it is used by all executables. BUG=459705 ==========
Updated description as the flag is called "-ObjC" not "-fObjC".
The CQ bit was checked by sdefresne@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024673002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024673002/20001
Message was sent while issue was closed.
Description was changed from ========== [iOS] Always pass "-ObjC" when linking iOS executables. Chrome on iOS needs to use "-ObjC" to link all symbols from static libraries that define at least one Objective-C category or class. Add it to the ios_app_bundle template so that it is used by all executables. BUG=459705 ========== to ========== [iOS] Always pass "-ObjC" when linking iOS executables. Chrome on iOS needs to use "-ObjC" to link all symbols from static libraries that define at least one Objective-C category or class. Add it to the ios_app_bundle template so that it is used by all executables. BUG=459705 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [iOS] Always pass "-ObjC" when linking iOS executables. Chrome on iOS needs to use "-ObjC" to link all symbols from static libraries that define at least one Objective-C category or class. Add it to the ios_app_bundle template so that it is used by all executables. BUG=459705 ========== to ========== [iOS] Always pass "-ObjC" when linking iOS executables. Chrome on iOS needs to use "-ObjC" to link all symbols from static libraries that define at least one Objective-C category or class. Add it to the ios_app_bundle template so that it is used by all executables. BUG=459705 Committed: https://crrev.com/ca860463e4432111af876304ff8ffea60c01ca9c Cr-Commit-Position: refs/heads/master@{#397087} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/ca860463e4432111af876304ff8ffea60c01ca9c Cr-Commit-Position: refs/heads/master@{#397087} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
