Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 2019403002: [iOS] Do not use breakpad GTMLogger.m implementation. (Closed)

Created:
4 years, 6 months ago by sdefresne
Modified:
4 years, 6 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@{0}
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Do not use breakpad GTMLogger.m implementation. Chrome on iOS needs to link with "-fObjC" to keep all symbols from static library that defines at least one Objective-C category or class. Since both //breakpad:client and //third_party/google_toolbox_for_mac are linked and define the GTMLogger class, only one implementation can be used. Use the implementation from google_toolbox_for_mac on iOS as it is the one currently used by the gyp build. Fix the following linker failure: duplicate symbol _OBJC_METACLASS_$_GTMLogger in: obj/third_party/google_toolbox_for_mac/google_toolbox_for_mac/GTMLogger.o obj/breakpad/libclient.a(GTMLogger.o) BUG=459705 Committed: https://crrev.com/ff299d2e56c04bc61368510da0ed912a1fb75096 Cr-Commit-Position: refs/heads/master@{#396857}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M breakpad/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
sdefresne
Please take a look and send to CQ if LGTY.
4 years, 6 months ago (2016-05-30 14:51:23 UTC) #2
Mark Mentovai
LGTM
4 years, 6 months ago (2016-05-31 16:18:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2019403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2019403002/1
4 years, 6 months ago (2016-05-31 16:19:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-31 17:50:21 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 17:51:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff299d2e56c04bc61368510da0ed912a1fb75096
Cr-Commit-Position: refs/heads/master@{#396857}

Powered by Google App Engine
This is Rietveld 408576698