Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2024663002: Implement SetWrapperReferenceTo idl attribute within traceWrappers for svg elements (Closed)

Created:
4 years, 6 months ago by Marcel Hlopko
Modified:
4 years, 6 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement SetWrapperReferenceTo idl attribute within traceWrappers for svg elements Follow status of tracing SetWrapperReferenceTo here: https://docs.google.com/a/google.com/spreadsheets/d/1S-LZ6rovnfg8-yw3a74KEC7CvUGVDjp994AXYj7c9wg/edit?usp=sharing LOG=no BUG=468240 Committed: https://crrev.com/d1f220a7e8889ac3cf75c4d36afac7609ca87fdb Cr-Commit-Position: refs/heads/master@{#396749}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -1 line) Patch
M third_party/WebKit/Source/core/svg/SVGAngleTearOff.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAngleTearOff.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedAngle.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedAngle.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedBoolean.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedEnumeration.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedInteger.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedInteger.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedLength.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedLength.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedLengthList.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedNumber.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedNumber.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedNumberList.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedPreserveAspectRatio.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedRect.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedString.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedString.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedTransformList.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGLengthListTearOff.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGLengthTearOff.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGLengthTearOff.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGMatrixTearOff.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGMatrixTearOff.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGNumberListTearOff.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGNumberTearOff.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGNumberTearOff.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPointListTearOff.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPointTearOff.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPointTearOff.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPreserveAspectRatioTearOff.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPreserveAspectRatioTearOff.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGRectTearOff.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGRectTearOff.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGStringListTearOff.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGStringListTearOff.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTransformListTearOff.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTransformListTearOff.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTransformTearOff.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGTransformTearOff.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGViewSpec.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGViewSpec.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/properties/SVGPropertyTearOff.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Marcel Hlopko
Ptal.
4 years, 6 months ago (2016-05-30 14:17:43 UTC) #2
haraken
LGTM
4 years, 6 months ago (2016-05-30 14:37:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024663002/1
4 years, 6 months ago (2016-05-30 14:38:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/230184)
4 years, 6 months ago (2016-05-30 17:15:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024663002/1
4 years, 6 months ago (2016-05-30 17:22:01 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-30 19:03:13 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-05-30 19:04:30 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1f220a7e8889ac3cf75c4d36afac7609ca87fdb
Cr-Commit-Position: refs/heads/master@{#396749}

Powered by Google App Engine
This is Rietveld 408576698