[Autofill] Register AutofillDriver mojo interface earlier.

[Autofill] Register AutofillDriver mojo interface earlier.

To avoid the following error msg which would show if renderer tried
to connect to AutofillDriver interface before it is created.
"[31483:31483:0530/152039:ERROR:service_registry_impl.cc(95)]
autofill::mojom::AutofillDriver not found"

BUG=none

Committed: https://crrev.com/04b276e5857b3c36f18908a75c490fd748ba70dc
Cr-Commit-Position: refs/heads/master@{#397016}

[leonhsl(Using Gerrit), 2016-05-30 09:20:28]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-30 09:20:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2024603002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2024603002/1

[leonhsl(Using Gerrit), 2016-05-30 09:32:55]

leon.han@intel.com changed reviewers:
+ mathp@chromium.org, sky@chromium.org, vabr@chromium.org

[leonhsl(Using Gerrit), 2016-05-30 09:32:56]

Hi, while I'm trying to mojofy other autofill IPCs, I noticed that this should
the proper way to manage AutofillDriver mojo interfaces. 
Would you PTAL at this? Thanks~

vabr@, mathp@: For autofill OWNER review.

sky@: For chrome/browser/chrome_content_browser_client.cc OWNER review.

[commit-bot: I haz the power, 2016-05-30 09:45:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-30 09:45:27]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vabr (Chromium), 2016-05-30 10:16:09]

LGTM with a question.
Thanks!
Vaclav

https://codereview.chromium.org/2024603002/diff/1/components/autofill/content...
File components/autofill/content/renderer/autofill_agent.cc (right):

https://codereview.chromium.org/2024603002/diff/1/components/autofill/content...
components/autofill/content/renderer/autofill_agent.cc:774: if
(mojo_autofill_driver_.is_bound() &&
Would this crash on every first call, because mojo_autofill_driver_ is null?

[leonhsl(Using Gerrit), 2016-05-30 10:52:01]

Hi, Thanks a lot for kindly review~

https://codereview.chromium.org/2024603002/diff/1/components/autofill/content...
File components/autofill/content/renderer/autofill_agent.cc (right):

https://codereview.chromium.org/2024603002/diff/1/components/autofill/content...
components/autofill/content/renderer/autofill_agent.cc:774: if
(mojo_autofill_driver_.is_bound() &&
On 2016/05/30 10:16:09, vabr (Chromium) wrote:
> Would this crash on every first call, because mojo_autofill_driver_ is null?

InterfacePtr is a wrapper class maybe containing one raw pointer of proxy bound
with one message pipe handle. Its null(uninitialized) state just means there has
no bound message pipe handle and the raw pointer is null, while the InterfacePtr
itself is a valid instance.

[leonhsl(Using Gerrit), 2016-05-30 10:52:08]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-30 10:52:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2024603002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2024603002/1

[vabr (Chromium), 2016-05-30 10:58:21]

https://codereview.chromium.org/2024603002/diff/1/components/autofill/content...
File components/autofill/content/renderer/autofill_agent.cc (right):

https://codereview.chromium.org/2024603002/diff/1/components/autofill/content...
components/autofill/content/renderer/autofill_agent.cc:774: if
(mojo_autofill_driver_.is_bound() &&
On 2016/05/30 10:52:01, leonhsl wrote:
> On 2016/05/30 10:16:09, vabr (Chromium) wrote:
> > Would this crash on every first call, because mojo_autofill_driver_ is null?
> 
> InterfacePtr is a wrapper class maybe containing one raw pointer of proxy
bound
> with one message pipe handle. Its null(uninitialized) state just means there
has
> no bound message pipe handle and the raw pointer is null, while the
InterfacePtr
> itself is a valid instance.

Acknowledged, thanks for the explanation.

[commit-bot: I haz the power, 2016-05-30 11:26:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-30 11:26:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[leonhsl(Using Gerrit), 2016-05-31 01:57:41]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-31 01:57:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2024603002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2024603002/1

[commit-bot: I haz the power, 2016-05-31 02:25:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-31 02:25:46]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[leonhsl(Using Gerrit), 2016-05-31 03:22:08]

The CQ bit was checked by leon.han@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2016-05-31 03:22:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2024603002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2024603002/20001

[commit-bot: I haz the power, 2016-05-31 04:23:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-31 04:23:53]

Dry run: This issue passed the CQ dry run.

[sky, 2016-05-31 16:56:26]

LGTM

[leonhsl(Using Gerrit), 2016-06-01 01:28:50]

The CQ bit was checked by leon.han@intel.com

[leonhsl(Using Gerrit), 2016-06-01 01:28:51]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/2024603002/#ps20001
(title: "Fix trybot failure")

[commit-bot: I haz the power, 2016-06-01 01:29:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2024603002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2024603002/20001

[commit-bot: I haz the power, 2016-06-01 01:34:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-01 01:36:12]

Description was changed from

==========
[Autofill] Register AutofillDriver mojo interface earlier.

To avoid the following error msg which would show if renderer tried
to connect to AutofillDriver interface before it is created.
"[31483:31483:0530/152039:ERROR:service_registry_impl.cc(95)]
autofill::mojom::AutofillDriver not found"

BUG=none
==========

to

==========
[Autofill] Register AutofillDriver mojo interface earlier.

To avoid the following error msg which would show if renderer tried
to connect to AutofillDriver interface before it is created.
"[31483:31483:0530/152039:ERROR:service_registry_impl.cc(95)]
autofill::mojom::AutofillDriver not found"

BUG=none

Committed: https://crrev.com/04b276e5857b3c36f18908a75c490fd748ba70dc
Cr-Commit-Position: refs/heads/master@{#397016}
==========

[commit-bot: I haz the power, 2016-06-01 01:36:13]

Patchset 2 (id:??) landed as
https://crrev.com/04b276e5857b3c36f18908a75c490fd748ba70dc
Cr-Commit-Position: refs/heads/master@{#397016}