components/autofill/content/browser/content_autofill_driver.cc - Issue 2024603002: [Autofill] Register AutofillDriver mojo interface earlier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/browser/content_autofill_driver.cc

Issue 2024603002: [Autofill] Register AutofillDriver mojo interface earlier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix trybot failure Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | components/autofill/content/browser/content_autofill_driver_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/browser/content_autofill_driver.cc

diff --git a/components/autofill/content/browser/content_autofill_driver.cc b/components/autofill/content/browser/content_autofill_driver.cc

index ed4860c41c4950f551f7a83457684b3b12cb3780..4bb5301a5587deba10d17714280a3fb5490c7000 100644

--- a/components/autofill/content/browser/content_autofill_driver.cc

+++ b/components/autofill/content/browser/content_autofill_driver.cc

@@ -42,13 +42,6 @@ ContentAutofillDriver::ContentAutofillDriver(

enable_download_manager)),

autofill_external_delegate_(autofill_manager_.get(), this) {

autofill_manager_->SetExternalDelegate(&autofill_external_delegate_);

- // ContentAutofillDriver is guaranteed to outlive |render_frame_host|,

- // as the ContentAutofillDriver instance will be destroyed in

- // ContentAutofillDriverFactory::RenderFrameDeleted, which is a notification

- // of |render_frame_host| destruction.

- render_frame_host->GetServiceRegistry()->AddService(

- base::Bind(&ContentAutofillDriver::BindRequest, base::Unretained(this)));

}

ContentAutofillDriver::~ContentAutofillDriver() {}