Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2024553002: Fill in the current host name in the Mojo host resolver service when requesting our own IP address. (Closed)

Created:
4 years, 6 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Fill in the current host name in the Mojo host resolver service when requesting our own IP address. The V8 proxy resolver uses GetHostName() as the host in the implementation of myIpAddress(). However, that may not return the expected hostname when running inside the sandbox. Instead, use the request's "is_my_ip_address" field to fill in the correct host name in the browser before forwarding the resolve request to the DNS resolver. BUG=615084 Review-Url: https://codereview.chromium.org/2011293002 Cr-Commit-Position: refs/heads/master@{#396424} (cherry picked from commit 3a6cd21dab6a285179b02a05e980091c86545d66) Committed: https://chromium.googlesource.com/chromium/src/+/a89910068adf8652d83d05b0c3f47d124b752b21

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M net/dns/mojo_host_resolver_impl.cc View 2 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Anand Mistry (off Chromium)
4 years, 6 months ago (2016-05-30 01:11:42 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a89910068adf8652d83d05b0c3f47d124b752b21.

Powered by Google App Engine
This is Rietveld 408576698