Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2011293002: Fill in the current host name in the Mojo host resolver service when requesting our own IP address. (Closed)

Created:
4 years, 6 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 6 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fill in the current host name in the Mojo host resolver service when requesting our own IP address. The V8 proxy resolver uses GetHostName() as the host in the implementation of myIpAddress(). However, that may not return the expected hostname when running inside the sandbox. Instead, use the request's "is_my_ip_address" field to fill in the correct host name in the browser before forwarding the resolve request to the DNS resolver. BUG=615084 Committed: https://crrev.com/3a6cd21dab6a285179b02a05e980091c86545d66 Cr-Commit-Position: refs/heads/master@{#396424}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M net/dns/mojo_host_resolver_impl.cc View 2 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Anand Mistry (off Chromium)
Simple, mergeable patch for M51. Linux doesn't appear to be affected, so I still need ...
4 years, 6 months ago (2016-05-27 06:33:14 UTC) #2
eroman
lgtm
4 years, 6 months ago (2016-05-27 06:38:43 UTC) #3
Anand Mistry (off Chromium)
FYI, manually verified fix on windows 10.
4 years, 6 months ago (2016-05-27 08:05:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011293002/1
4 years, 6 months ago (2016-05-27 08:05:35 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-27 08:08:57 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 08:10:54 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a6cd21dab6a285179b02a05e980091c86545d66
Cr-Commit-Position: refs/heads/master@{#396424}

Powered by Google App Engine
This is Rietveld 408576698