Convert MimeRegistry to use mojo.

Convert MimeRegistry to use mojo.

This also adds an optional task runner parameter to
ServiceRegistry::AddService() so mojo service factories can be run on
their preferred thread without needing to write a boilerplate forwarding
function to post to that thread.

BUG=577685
Committed: https://crrev.com/c0fe274f846d0483a7ca32c1ba47875e854f6a1c
Cr-Commit-Position: refs/heads/master@{#397959}

[Sam McNally, 2016-06-01 04:03:08]

Patchset #2 (id:20001) has been deleted

[Sam McNally, 2016-06-01 04:03:30]

Patchset #1 (id:1) has been deleted

[Sam McNally, 2016-06-01 06:50:23]

Patchset #3 (id:80001) has been deleted

[Sam McNally, 2016-06-01 06:50:30]

Patchset #2 (id:60001) has been deleted

[Sam McNally, 2016-06-01 06:50:39]

Patchset #1 (id:40001) has been deleted

[Sam McNally, 2016-06-02 03:08:32]

Patchset #1 (id:100001) has been deleted

[Sam McNally, 2016-06-02 03:10:50]

Patchset #1 (id:120001) has been deleted

[Sam McNally, 2016-06-02 04:34:33]

Description was changed from

==========
Convert MimeRegistry to use mojo.

BUG=577685
==========

to

==========
Convert MimeRegistry to use mojo.

This also adds an optional task runner parameter to
ServiceRegistry::AddService() so mojo service factories can be run on
their preferred thread without needing to write a boilerplate forwarding
function to post to that thread.

BUG=577685
==========

[Sam McNally, 2016-06-02 07:24:35]

sammc@chromium.org changed reviewers:
+ creis@chromium.org, dcheng@chromium.org

[Sam McNally, 2016-06-02 07:24:36]

+dcheng for *message* and third_party/WebKit

+creis for content/

[Charlie Reis, 2016-06-02 16:27:52]

creis@chromium.org changed reviewers:
+ nasko@chromium.org

[Charlie Reis, 2016-06-02 16:27:53]

I won't be able to get to this soon, so Nasko said he could review it. 
(Thanks!)

[Charlie Reis, 2016-06-02 16:39:18]

Description was changed from

==========
Convert MimeRegistry to use mojo.

This also adds an optional task runner parameter to
ServiceRegistry::AddService() so mojo service factories can be run on
their preferred thread without needing to write a boilerplate forwarding
function to post to that thread.

BUG=577685
==========

to

==========
Convert MimeRegistry to use mojo.

This also adds an optional task runner parameter to
ServiceRegistry::AddService() so mojo service factories can be run on
their preferred thread without needing to write a boilerplate forwarding
function to post to that thread.

BUG=577685
==========

[Charlie Reis, 2016-06-02 16:39:18]

creis@chromium.org changed reviewers:
- creis@chromium.org

[nasko, 2016-06-02 21:31:41]

Couple of nits and a question to clarify this for myself.

https://codereview.chromium.org/2024363002/diff/140001/content/browser/mime_r...
File content/browser/mime_registry_impl.cc (right):

https://codereview.chromium.org/2024363002/diff/140001/content/browser/mime_r...
content/browser/mime_registry_impl.cc:27: const
GetMimeTypeFromExtensionCallback& callback) {
nit: Since this is expected to be invoked on the FILE thread, why not add a
DCHECK_CURRENTLY_ON?

https://codereview.chromium.org/2024363002/diff/140001/content/browser/mime_r...
File content/browser/mime_registry_impl.h (right):

https://codereview.chromium.org/2024363002/diff/140001/content/browser/mime_r...
content/browser/mime_registry_impl.h:1: // Copyright (c) 2011 The Chromium
Authors. All rights reserved.
No (c) and 2016, since this is a new file, not a rename/move.

https://codereview.chromium.org/2024363002/diff/140001/content/common/mojo/se...
File content/common/mojo/service_registry_impl.cc (right):

https://codereview.chromium.org/2024363002/diff/140001/content/common/mojo/se...
content/common/mojo/service_registry_impl.cc:123:
factory.Run(std::move(handle));
More for my own education - where does Mojo guarantee that object constructed on
a specific thread is only called on the same thread?

[Sam McNally, 2016-06-02 23:46:41]

Patchset #2 (id:160001) has been deleted

[Sam McNally, 2016-06-02 23:49:39]

https://codereview.chromium.org/2024363002/diff/140001/content/browser/mime_r...
File content/browser/mime_registry_impl.cc (right):

https://codereview.chromium.org/2024363002/diff/140001/content/browser/mime_r...
content/browser/mime_registry_impl.cc:27: const
GetMimeTypeFromExtensionCallback& callback) {
On 2016/06/02 21:31:41, nasko (slow) wrote:
> nit: Since this is expected to be invoked on the FILE thread, why not add a
> DCHECK_CURRENTLY_ON?

Done.

https://codereview.chromium.org/2024363002/diff/140001/content/browser/mime_r...
File content/browser/mime_registry_impl.h (right):

https://codereview.chromium.org/2024363002/diff/140001/content/browser/mime_r...
content/browser/mime_registry_impl.h:1: // Copyright (c) 2011 The Chromium
Authors. All rights reserved.
On 2016/06/02 21:31:41, nasko (slow) wrote:
> No (c) and 2016, since this is a new file, not a rename/move.

Done.

https://codereview.chromium.org/2024363002/diff/140001/content/common/mojo/se...
File content/common/mojo/service_registry_impl.cc (right):

https://codereview.chromium.org/2024363002/diff/140001/content/common/mojo/se...
content/common/mojo/service_registry_impl.cc:123:
factory.Run(std::move(handle));
On 2016/06/02 21:31:41, nasko (slow) wrote:
> More for my own education - where does Mojo guarantee that object constructed
on
> a specific thread is only called on the same thread?

https://code.google.com/p/chromium/codesearch/#chromium/src/mojo/public/cpp/b...

[nasko, 2016-06-03 15:54:46]

LGTM

[dcheng, 2016-06-03 17:43:04]

LGTM

Just to confirm: the new mojo method is sync because all the existing Blink code
expects to do the MIME type mapping synchronously, right?

[Sam McNally, 2016-06-05 23:41:15]

On 2016/06/03 17:43:04, dcheng wrote:
> LGTM
> 
> Just to confirm: the new mojo method is sync because all the existing Blink
code
> expects to do the MIME type mapping synchronously, right?

Yes.

[Sam McNally, 2016-06-05 23:43:24]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2016-06-05 23:43:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2024363002/180001

[commit-bot: I haz the power, 2016-06-06 01:38:10]

Description was changed from

==========
Convert MimeRegistry to use mojo.

This also adds an optional task runner parameter to
ServiceRegistry::AddService() so mojo service factories can be run on
their preferred thread without needing to write a boilerplate forwarding
function to post to that thread.

BUG=577685
==========

to

==========
Convert MimeRegistry to use mojo.

This also adds an optional task runner parameter to
ServiceRegistry::AddService() so mojo service factories can be run on
their preferred thread without needing to write a boilerplate forwarding
function to post to that thread.

BUG=577685
==========

[commit-bot: I haz the power, 2016-06-06 01:38:11]

Committed patchset #2 (id:180001)

[commit-bot: I haz the power, 2016-06-06 01:39:41]

Description was changed from

==========
Convert MimeRegistry to use mojo.

This also adds an optional task runner parameter to
ServiceRegistry::AddService() so mojo service factories can be run on
their preferred thread without needing to write a boilerplate forwarding
function to post to that thread.

BUG=577685
==========

to

==========
Convert MimeRegistry to use mojo.

This also adds an optional task runner parameter to
ServiceRegistry::AddService() so mojo service factories can be run on
their preferred thread without needing to write a boilerplate forwarding
function to post to that thread.

BUG=577685

Committed: https://crrev.com/c0fe274f846d0483a7ca32c1ba47875e854f6a1c
Cr-Commit-Position: refs/heads/master@{#397959}
==========

[commit-bot: I haz the power, 2016-06-06 01:39:43]

Patchset 2 (id:??) landed as
https://crrev.com/c0fe274f846d0483a7ca32c1ba47875e854f6a1c
Cr-Commit-Position: refs/heads/master@{#397959}