Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Issue 2024323002: Fixing Regression Bug where context menu doesn't appear on long press (Closed)

Created:
4 years, 6 months ago by amaralp
Modified:
4 years, 6 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, jam, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing Regression Bug where context menu doesn't appear on long press Added a Setting to tell Blink whether or not to always show the context menu on a long press. BUG=616060 Committed: https://crrev.com/9a4f551361bcc1ea8f801d44b16b2d086feef2df Cr-Commit-Position: refs/heads/master@{#397203}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -2 lines) Patch
M content/public/common/web_preferences.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/web_preferences.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Settings.in View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ContextMenuClientImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ContextMenuClientImpl.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebSettingsImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebSettingsImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 5 chunks +25 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebSettings.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 25 (13 generated)
amaralp
On 2016/05/31 23:17:54, amaralp wrote: > mailto:amaralp@chromium.org changed reviewers: > + mailto:aelias@chromium.org PTAL
4 years, 6 months ago (2016-05-31 23:18:05 UTC) #3
aelias_OOO_until_Jul13
lgtm, adding sievers@ for OWNERS approval of new setting in content/
4 years, 6 months ago (2016-05-31 23:23:19 UTC) #6
aelias_OOO_until_Jul13
Actually adding sievers@, PTAL.
4 years, 6 months ago (2016-05-31 23:23:41 UTC) #8
no sievers
content lgtm stamp
4 years, 6 months ago (2016-05-31 23:25:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024323002/1
4 years, 6 months ago (2016-05-31 23:29:32 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024323002/1
4 years, 6 months ago (2016-05-31 23:30:14 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/192529)
4 years, 6 months ago (2016-05-31 23:39:25 UTC) #16
amaralp
Added bokan@ for OWNERS approval of Settings.in, PTAL
4 years, 6 months ago (2016-05-31 23:47:55 UTC) #18
bokan
On 2016/05/31 23:47:55, amaralp wrote: > Added bokan@ for OWNERS approval of Settings.in, PTAL lgtm
4 years, 6 months ago (2016-06-01 12:59:23 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024323002/1
4 years, 6 months ago (2016-06-01 17:28:14 UTC) #21
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 19:24:29 UTC) #23
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 19:25:48 UTC) #25
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a4f551361bcc1ea8f801d44b16b2d086feef2df
Cr-Commit-Position: refs/heads/master@{#397203}

Powered by Google App Engine
This is Rietveld 408576698