third_party/WebKit/Source/web/ContextMenuClientImpl.h - Issue 2024323002: Fixing Regression Bug where context menu doesn't appear on long press

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/web/ContextMenuClientImpl.h

Issue 2024323002: Fixing Regression Bug where context menu doesn't appear on long press (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2009 Google Inc. All rights reserved.	2 * Copyright (C) 2009 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 28 matching lines...) Expand all Loading...
39 struct WebContextMenuData;	39 struct WebContextMenuData;

40	40

41 class ContextMenuClientImpl final : public ContextMenuClient {	41 class ContextMenuClientImpl final : public ContextMenuClient {

42 public:	42 public:

43 explicit ContextMenuClientImpl(WebViewImpl* webView) : m_webView(webView) { }	43 explicit ContextMenuClientImpl(WebViewImpl* webView) : m_webView(webView) { }

44 ~ContextMenuClientImpl() override {}	44 ~ContextMenuClientImpl() override {}

45 bool showContextMenu(const ContextMenu*, bool fromTouch) override;	45 bool showContextMenu(const ContextMenu*, bool fromTouch) override;

46 void clearContextMenu() override;	46 void clearContextMenu() override;

47 private:	47 private:

48 void populateCustomMenuItems(const ContextMenu, WebContextMenuData);	48 void populateCustomMenuItems(const ContextMenu, WebContextMenuData);

	49 bool shouldShowContextMenuFromTouch(const blink::WebContextMenuData&);

49 WebViewImpl* m_webView;	50 WebViewImpl* m_webView;

50 };	51 };

51	52

52 } // namespace blink	53 } // namespace blink

53	54

54 #endif // ContextMenuClientImpl_h	55 #endif // ContextMenuClientImpl_h

OLD	NEW

« no previous file with comments | « third_party/WebKit/Source/core/frame/Settings.in ('k') | third_party/WebKit/Source/web/ContextMenuClientImpl.cpp » ('j') | no next file with comments »