Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2024313002: Moves mash/wm/public -> ash/public (Closed)

Created:
4 years, 6 months ago by sky
Modified:
4 years, 6 months ago
Reviewers:
msw
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, dzhioev+watch_chromium.org, achuith+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, oshima+watch_chromium.org, kalyank, darin (slow to review), ben+mojo_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves mash/wm/public -> ash/public BUG=616265 TEST=none R=msw@chromium.org Committed: https://crrev.com/8848f00762e3d5a6c5c8a20423317f6fe8c66b68 Cr-Commit-Position: refs/heads/master@{#397058}

Patch Set 1 #

Patch Set 2 : moar #

Patch Set 3 : extra #

Total comments: 12

Patch Set 4 : feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -391 lines) Patch
A + ash/public/interfaces/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/public/interfaces/ash_window_type.mojom View 1 1 chunk +1 line, -1 line 0 comments Download
A + ash/public/interfaces/container.mojom View 1 1 chunk +1 line, -1 line 0 comments Download
A + ash/public/interfaces/shelf_layout.mojom View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + ash/public/interfaces/user_window_controller.mojom View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/sysui/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M ash/sysui/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M ash/sysui/container_delegate_mus.cc View 1 2 chunks +7 lines, -9 lines 0 comments Download
M ash/sysui/manifest.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ash/sysui/shelf_delegate_mus.h View 1 2 4 chunks +9 lines, -9 lines 0 comments Download
M ash/sysui/shelf_delegate_mus.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M ash/sysui/sysui_application.cc View 1 2 3 7 chunks +32 lines, -35 lines 0 comments Download
M chrome/browser/chromeos/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M mash/DEPS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M mash/login/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mash/login/login.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M mash/screenlock/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mash/screenlock/screenlock.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M mash/unittests_manifest.json View 1 1 chunk +1 line, -1 line 0 comments Download
M mash/wm/BUILD.gn View 3 chunks +2 lines, -2 lines 0 comments Download
M mash/wm/bridge/wm_globals_mus.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M mash/wm/container_ids.h View 1 1 chunk +7 lines, -5 lines 0 comments Download
M mash/wm/container_ids.cc View 1 1 chunk +48 lines, -48 lines 0 comments Download
M mash/wm/property_util.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M mash/wm/property_util.cc View 1 2 chunks +11 lines, -10 lines 0 comments Download
D mash/wm/public/interfaces/BUILD.gn View 1 chunk +0 lines, -18 lines 0 comments Download
D mash/wm/public/interfaces/ash_window_type.mojom View 1 chunk +0 lines, -13 lines 0 comments Download
D mash/wm/public/interfaces/container.mojom View 1 chunk +0 lines, -46 lines 0 comments Download
D mash/wm/public/interfaces/shelf_layout.mojom View 1 chunk +0 lines, -14 lines 0 comments Download
D mash/wm/public/interfaces/user_window_controller.mojom View 1 chunk +0 lines, -38 lines 0 comments Download
M mash/wm/root_window_controller.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M mash/wm/root_window_controller.cc View 1 2 3 11 chunks +47 lines, -55 lines 0 comments Download
M mash/wm/shelf_layout_impl.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mash/wm/shelf_layout_manager.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M mash/wm/status_layout_manager.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M mash/wm/user_window_controller_impl.h View 1 3 chunks +6 lines, -5 lines 0 comments Download
M mash/wm/user_window_controller_impl.cc View 1 4 chunks +7 lines, -7 lines 0 comments Download
M mash/wm/window_manager.cc View 1 5 chunks +6 lines, -6 lines 0 comments Download
M mash/wm/window_manager_application.h View 1 5 chunks +14 lines, -14 lines 0 comments Download
M mash/wm/window_manager_application.cc View 1 2 chunks +8 lines, -7 lines 0 comments Download
M mash/wm/window_manager_unittest.cc View 1 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sky
4 years, 6 months ago (2016-06-01 00:10:41 UTC) #1
msw
lgtm with nits and qs. https://codereview.chromium.org/2024313002/diff/40001/ash/sysui/sysui_application.cc File ash/sysui/sysui_application.cc (right): https://codereview.chromium.org/2024313002/diff/40001/ash/sysui/sysui_application.cc#newcode151 ash/sysui/sysui_application.cc:151: properties[ash::mojom::kAshWindowType_Property] = q: why ...
4 years, 6 months ago (2016-06-01 01:51:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024313002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2024313002/60001
4 years, 6 months ago (2016-06-01 03:09:11 UTC) #5
sky
https://codereview.chromium.org/2024313002/diff/40001/ash/sysui/sysui_application.cc File ash/sysui/sysui_application.cc (right): https://codereview.chromium.org/2024313002/diff/40001/ash/sysui/sysui_application.cc#newcode151 ash/sysui/sysui_application.cc:151: properties[ash::mojom::kAshWindowType_Property] = On 2016/06/01 01:51:42, msw wrote: > q: ...
4 years, 6 months ago (2016-06-01 03:30:26 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-01 04:43:03 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 04:44:13 UTC) #9
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/8848f00762e3d5a6c5c8a20423317f6fe8c66b68
Cr-Commit-Position: refs/heads/master@{#397058}

Powered by Google App Engine
This is Rietveld 408576698