[stubs] Remove N-argument Hydrogen-based Array constructor stub

[stubs] Remove N-argument Hydrogen-based Array constructor stub

Instead, always tail call to the runtime. Also, cleanup the various versions
of the runtime call that is used for Array construction fallback. There can be
only one.

BUG=chromium:608675
LOG=N

Committed: https://crrev.com/c8ac0d8693f559795eeb3f3aaf386dde166fb2ab
Cr-Commit-Position: refs/heads/master@{#36888}

[danno, 2016-06-09 21:06:26]

Description was changed from

==========
[stubs] Implement N-argument constructor in TurboFan

BUG=chromium:608675
LOG=N
==========

to

==========
[stubs] Remove N-argument Hydrogen-based Array constructor stub 

Instead, always tail call to the runtime. Also, cleanup the various versions of
the runtime call that is used for Array construction fallback. There can be only
one.

BUG=chromium:608675
LOG=N
==========

[danno, 2016-06-09 21:06:26]

danno@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2016-06-10 05:29:39]

bmeurer@chromium.org changed reviewers:
+ mvstanton@chromium.org

[Benedikt Meurer, 2016-06-10 05:29:40]

LGTM with nit, but Michael might want to take a look too.

https://codereview.chromium.org/2024253002/diff/120001/src/runtime/runtime-ar...
File src/runtime/runtime-array.cc (right):

https://codereview.chromium.org/2024253002/diff/120001/src/runtime/runtime-ar...
src/runtime/runtime-array.cc:325: RUNTIME_FUNCTION(Runtime_ArrayConstructor) {
Nit: Can we keep the %NewArray name here?

[danno, 2016-06-10 06:28:13]

Description was changed from

==========
[stubs] Remove N-argument Hydrogen-based Array constructor stub 

Instead, always tail call to the runtime. Also, cleanup the various versions of
the runtime call that is used for Array construction fallback. There can be only
one.

BUG=chromium:608675
LOG=N
==========

to

==========
[stubs] Remove N-argument Hydrogen-based Array constructor stub 

Instead, always tail call to the runtime. Also, cleanup the various versions
of the runtime call that is used for Array construction fallback. There can be
only
one.

BUG=chromium:608675
LOG=N
==========

[danno, 2016-06-10 06:28:28]

Description was changed from

==========
[stubs] Remove N-argument Hydrogen-based Array constructor stub 

Instead, always tail call to the runtime. Also, cleanup the various versions
of the runtime call that is used for Array construction fallback. There can be
only
one.

BUG=chromium:608675
LOG=N
==========

to

==========
[stubs] Remove N-argument Hydrogen-based Array constructor stub 

Instead, always tail call to the runtime. Also, cleanup the various versions
of the runtime call that is used for Array construction fallback. There can be
only one.

BUG=chromium:608675
LOG=N
==========

[danno, 2016-06-10 06:28:42]

PTAL

[danno, 2016-06-10 06:29:45]

Feedback addressed.

https://codereview.chromium.org/2024253002/diff/120001/src/runtime/runtime-ar...
File src/runtime/runtime-array.cc (right):

https://codereview.chromium.org/2024253002/diff/120001/src/runtime/runtime-ar...
src/runtime/runtime-array.cc:325: RUNTIME_FUNCTION(Runtime_ArrayConstructor) {
On 2016/06/10 05:29:40, Benedikt Meurer wrote:
> Nit: Can we keep the %NewArray name here?

Done.

[mvstanton, 2016-06-10 10:30:59]

Fantastic cleanup!
LGTM.

[danno, 2016-06-10 10:57:52]

The CQ bit was checked by danno@chromium.org

[danno, 2016-06-10 10:57:53]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2024253002/#ps180001
(title: "Fix arm64")

[commit-bot: I haz the power, 2016-06-10 10:57:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2024253002/180001

[balazs.kilvady, 2016-06-10 10:59:03]

balazs.kilvady@imgtec.com changed reviewers:
+ balazs.kilvady@imgtec.com

[balazs.kilvady, 2016-06-10 10:59:04]

A small nit:

https://codereview.chromium.org/2024253002/diff/180001/src/mips/code-stubs-mi...
File src/mips/code-stubs-mips.cc (right):

https://codereview.chromium.org/2024253002/diff/180001/src/mips/code-stubs-mi...
src/mips/code-stubs-mips.cc:31: __ Push(a2);
Push(a1, a2) could be used instead of the above two pushes to save an add/sub
instruction. Also on MIPS64, arm, arm64.

[commit-bot: I haz the power, 2016-06-10 11:00:07]

Description was changed from

==========
[stubs] Remove N-argument Hydrogen-based Array constructor stub 

Instead, always tail call to the runtime. Also, cleanup the various versions
of the runtime call that is used for Array construction fallback. There can be
only one.

BUG=chromium:608675
LOG=N
==========

to

==========
[stubs] Remove N-argument Hydrogen-based Array constructor stub 

Instead, always tail call to the runtime. Also, cleanup the various versions
of the runtime call that is used for Array construction fallback. There can be
only one.

BUG=chromium:608675
LOG=N
==========

[commit-bot: I haz the power, 2016-06-10 11:00:08]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-06-10 11:02:04]

Description was changed from

==========
[stubs] Remove N-argument Hydrogen-based Array constructor stub 

Instead, always tail call to the runtime. Also, cleanup the various versions
of the runtime call that is used for Array construction fallback. There can be
only one.

BUG=chromium:608675
LOG=N
==========

to

==========
[stubs] Remove N-argument Hydrogen-based Array constructor stub

Instead, always tail call to the runtime. Also, cleanup the various versions
of the runtime call that is used for Array construction fallback. There can be
only one.

BUG=chromium:608675
LOG=N

Committed: https://crrev.com/c8ac0d8693f559795eeb3f3aaf386dde166fb2ab
Cr-Commit-Position: refs/heads/master@{#36888}
==========

[commit-bot: I haz the power, 2016-06-10 11:02:05]

Patchset 10 (id:??) landed as
https://crrev.com/c8ac0d8693f559795eeb3f3aaf386dde166fb2ab
Cr-Commit-Position: refs/heads/master@{#36888}