Index: src/arm64/code-stubs-arm64.cc |
diff --git a/src/arm64/code-stubs-arm64.cc b/src/arm64/code-stubs-arm64.cc |
index 8788f19b274b0b5b3c06fc75b5d38a3d3f5de596..aef953484e4b1262c0aac6500350a10f188c140b 100644 |
--- a/src/arm64/code-stubs-arm64.cc |
+++ b/src/arm64/code-stubs-arm64.cc |
@@ -22,49 +22,17 @@ |
namespace v8 { |
namespace internal { |
+#define __ ACCESS_MASM(masm) |
-static void InitializeArrayConstructorDescriptor( |
- Isolate* isolate, CodeStubDescriptor* descriptor, |
- int constant_stack_parameter_count) { |
- // cp: context |
- // x1: function |
- // x2: allocation site with elements kind |
- // x0: number of arguments to the constructor function |
- Address deopt_handler = Runtime::FunctionForId( |
- Runtime::kArrayConstructor)->entry; |
- |
- if (constant_stack_parameter_count == 0) { |
- descriptor->Initialize(deopt_handler, constant_stack_parameter_count, |
- JS_FUNCTION_STUB_MODE); |
- } else { |
- descriptor->Initialize(x0, deopt_handler, constant_stack_parameter_count, |
- JS_FUNCTION_STUB_MODE); |
- } |
-} |
- |
- |
-void ArrayNArgumentsConstructorStub::InitializeDescriptor( |
- CodeStubDescriptor* descriptor) { |
- InitializeArrayConstructorDescriptor(isolate(), descriptor, -1); |
-} |
- |
- |
-static void InitializeInternalArrayConstructorDescriptor( |
- Isolate* isolate, CodeStubDescriptor* descriptor, |
- int constant_stack_parameter_count) { |
- Address deopt_handler = Runtime::FunctionForId( |
- Runtime::kInternalArrayConstructor)->entry; |
- |
- if (constant_stack_parameter_count == 0) { |
- descriptor->Initialize(deopt_handler, constant_stack_parameter_count, |
- JS_FUNCTION_STUB_MODE); |
- } else { |
- descriptor->Initialize(x0, deopt_handler, constant_stack_parameter_count, |
- JS_FUNCTION_STUB_MODE); |
- } |
+void ArrayNArgumentsConstructorStub::Generate(MacroAssembler* masm) { |
+ __ Mov(x5, Operand(x0, LSL, kPointerSizeLog2)); |
+ __ Str(x1, MemOperand(jssp, x5)); |
+ __ Push(x1); |
+ __ Push(x2); |
+ __ Add(x0, x0, Operand(3)); |
+ __ TailCallRuntime(Runtime::kNewArray); |
} |
- |
void FastArrayPushStub::InitializeDescriptor(CodeStubDescriptor* descriptor) { |
Address deopt_handler = Runtime::FunctionForId(Runtime::kArrayPush)->entry; |
descriptor->Initialize(x0, deopt_handler, -1, JS_FUNCTION_STUB_MODE); |
@@ -76,15 +44,6 @@ void FastFunctionBindStub::InitializeDescriptor( |
descriptor->Initialize(x0, deopt_handler, -1, JS_FUNCTION_STUB_MODE); |
} |
-void InternalArrayNArgumentsConstructorStub::InitializeDescriptor( |
- CodeStubDescriptor* descriptor) { |
- InitializeInternalArrayConstructorDescriptor(isolate(), descriptor, -1); |
-} |
- |
- |
-#define __ ACCESS_MASM(masm) |
- |
- |
void HydrogenCodeStub::GenerateLightweightMiss(MacroAssembler* masm, |
ExternalReference miss) { |
// Update the static counter each time a new code stub is generated. |
@@ -980,7 +939,7 @@ void CodeStub::GenerateStubsAheadOfTime(Isolate* isolate) { |
CEntryStub::GenerateAheadOfTime(isolate); |
StoreBufferOverflowStub::GenerateFixedRegStubsAheadOfTime(isolate); |
StubFailureTrampolineStub::GenerateAheadOfTime(isolate); |
- ArrayConstructorStubBase::GenerateStubsAheadOfTime(isolate); |
+ CommonArrayConstructorStub::GenerateStubsAheadOfTime(isolate); |
CreateAllocationSiteStub::GenerateAheadOfTime(isolate); |
CreateWeakCellStub::GenerateAheadOfTime(isolate); |
BinaryOpICStub::GenerateAheadOfTime(isolate); |
@@ -4433,19 +4392,13 @@ static void ArrayConstructorStubAheadOfTimeHelper(Isolate* isolate) { |
} |
} |
- |
-void ArrayConstructorStubBase::GenerateStubsAheadOfTime(Isolate* isolate) { |
+void CommonArrayConstructorStub::GenerateStubsAheadOfTime(Isolate* isolate) { |
ArrayConstructorStubAheadOfTimeHelper<ArrayNoArgumentConstructorStub>( |
isolate); |
ArrayConstructorStubAheadOfTimeHelper<ArraySingleArgumentConstructorStub>( |
isolate); |
- ArrayConstructorStubAheadOfTimeHelper<ArrayNArgumentsConstructorStub>( |
- isolate); |
-} |
- |
- |
-void InternalArrayConstructorStubBase::GenerateStubsAheadOfTime( |
- Isolate* isolate) { |
+ ArrayNArgumentsConstructorStub stub(isolate); |
+ stub.GetCode(); |
ElementsKind kinds[2] = { FAST_ELEMENTS, FAST_HOLEY_ELEMENTS }; |
for (int i = 0; i < 2; i++) { |
// For internal arrays we only need a few things |
@@ -4453,8 +4406,6 @@ void InternalArrayConstructorStubBase::GenerateStubsAheadOfTime( |
stubh1.GetCode(); |
InternalArraySingleArgumentConstructorStub stubh2(isolate, kinds[i]); |
stubh2.GetCode(); |
- InternalArrayNArgumentsConstructorStub stubh3(isolate, kinds[i]); |
- stubh3.GetCode(); |
} |
} |
@@ -4478,14 +4429,15 @@ void ArrayConstructorStub::GenerateDispatchToArrayStub( |
__ Bind(&n_case); |
// N arguments. |
- CreateArrayDispatch<ArrayNArgumentsConstructorStub>(masm, mode); |
- |
+ ArrayNArgumentsConstructorStub stub(masm->isolate()); |
+ __ TailCallStub(&stub); |
} else if (argument_count() == NONE) { |
CreateArrayDispatch<ArrayNoArgumentConstructorStub>(masm, mode); |
} else if (argument_count() == ONE) { |
CreateArrayDispatchOneArgument(masm, mode); |
} else if (argument_count() == MORE_THAN_ONE) { |
- CreateArrayDispatch<ArrayNArgumentsConstructorStub>(masm, mode); |
+ ArrayNArgumentsConstructorStub stub(masm->isolate()); |
+ __ TailCallStub(&stub); |
} else { |
UNREACHABLE(); |
} |
@@ -4600,7 +4552,7 @@ void InternalArrayConstructorStub::GenerateCase( |
__ Bind(&n_case); |
// N arguments. |
- InternalArrayNArgumentsConstructorStub stubN(isolate(), kind); |
+ ArrayNArgumentsConstructorStub stubN(isolate()); |
__ TailCallStub(&stubN); |
} |