Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp

Issue 2024073002: Add callbacks to ScriptCustomElementDefinition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix when no callbacks, cleanup, and reset-result Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp
diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp b/third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp
index 618fa6158733ce98c0e8a201fb189d03966b939a..eec302d45cc39b454205888f5bae2a3e4358263c 100644
--- a/third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp
+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp
@@ -84,7 +84,8 @@ void CustomElementsRegistry::define(
// TODO(dominicc): Implement steps:
// 5: localName
// 6-7: extends processing
- // 8-9: observed attributes caching
+
+ // 8-9: observed attributes caching is done below, together with callbacks.
// TODO(dominicc): Add a test where the prototype getter destroys
// the context.
@@ -92,11 +93,14 @@ void CustomElementsRegistry::define(
if (!builder.checkPrototype())
return;
- // TODO(dominicc): Implement steps:
+ // 8-9: observed attributes caching
// 12-13: connected callback
// 14-15: disconnected callback
// 16-17: attribute changed callback
+ if (!builder.cacheProperties())
+ return;
+
// TODO(dominicc): Add a test where retrieving the prototype
// recursively calls define with the same name.

Powered by Google App Engine
This is Rietveld 408576698