third_party/WebKit/Source/core/dom/custom/CustomElementDefinitionBuilder.h - Issue 2024073002: Add callbacks to ScriptCustomElementDefinition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementDefinitionBuilder.h

Issue 2024073002: Add callbacks to ScriptCustomElementDefinition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix when no callbacks, cleanup, and reset-result Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinitionBuilder.cpp ('K') | « third_party/WebKit/Source/bindings/core/v8/V8Binding.h ('k') | third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/CustomElementDefinitionBuilder.h

diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinitionBuilder.h b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinitionBuilder.h

index 7c8dcd9cd0c57b7c5c568486968b4e56e6443333..35b644109d67bb450c70070d476a2d68844d63d6 100644

--- a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinitionBuilder.h

+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinitionBuilder.h

@@ -43,6 +43,10 @@ public:

// processing should not proceed.

virtual bool checkPrototype() = 0;

+ // Cache properties for build to use. Return false if processing

+ // should not proceed.

+ virtual bool cacheProperties() = 0;

// Produce the definition. This must produce a definition.

virtual CustomElementDefinition* build(const CustomElementDescriptor&) = 0;

};