Add callbacks to ScriptCustomElementDefinition

third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp

Index: third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp
diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp b/third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp
index 618fa6158733ce98c0e8a201fb189d03966b939a..9526a38314b38cecae421b4952b23643e187e837 100644
--- a/third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp
+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementsRegistry.cpp
@@ -84,7 +84,10 @@ void CustomElementsRegistry::define(
     // TODO(dominicc): Implement steps:
     // 5: localName
     // 6-7: extends processing
-    // 8-9: observed attributes caching
+
+    // 8-9: observed attributes caching is done below, together with callbacks.
+    // TODO(kojii): https://github.com/whatwg/html/issues/1373 for the ordering.
+    // When it's resolved, revisit if this code needs changes.
 
     // TODO(dominicc): Add a test where the prototype getter destroys
     // the context.
@@ -92,11 +95,14 @@ void CustomElementsRegistry::define(
     if (!builder.checkPrototype())
         return;
 
-    // TODO(dominicc): Implement steps:
+    // 8-9: observed attributes caching
     // 12-13: connected callback
     // 14-15: disconnected callback
     // 16-17: attribute changed callback
 
+    if (!builder.cacheProperties())
+        return;
+
     // TODO(dominicc): Add a test where retrieving the prototype
     // recursively calls define with the same name.