 Chromium Code Reviews
 Chromium Code Reviews Issue 2024073002:
  Add callbacks to ScriptCustomElementDefinition  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 2024073002:
  Add callbacks to ScriptCustomElementDefinition  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: third_party/WebKit/Source/bindings/core/v8/V8Binding.h | 
| diff --git a/third_party/WebKit/Source/bindings/core/v8/V8Binding.h b/third_party/WebKit/Source/bindings/core/v8/V8Binding.h | 
| index 775169767355d1d4723ef39e694b5d40de8bb3d4..ca221f4eeb16016c698808cae9c26e2ad3454cdb 100644 | 
| --- a/third_party/WebKit/Source/bindings/core/v8/V8Binding.h | 
| +++ b/third_party/WebKit/Source/bindings/core/v8/V8Binding.h | 
| @@ -775,6 +775,17 @@ struct NativeValueTraits<String> { | 
| }; | 
| template<> | 
| +struct NativeValueTraits<AtomicString> { | 
| + static inline String nativeValue(v8::Isolate* isolate, v8::Local<v8::Value> value, ExceptionState& exceptionState) | 
| 
haraken
2016/06/06 01:39:15
Why do you want to return a String for NativeValue
 
kojii
2016/06/06 11:12:35
Done, that was typo, thank you for catching.
 | 
| + { | 
| + V8StringResource<> stringValue(value); | 
| + if (!stringValue.prepare(exceptionState)) | 
| + return String(); | 
| + return stringValue; | 
| + } | 
| +}; | 
| + | 
| +template<> | 
| struct NativeValueTraits<int> { | 
| static inline int nativeValue(v8::Isolate* isolate, v8::Local<v8::Value> value, ExceptionState& exceptionState) | 
| { |