|
Revert of Uses the activedescendant_changed event received from Blink to fire the right focus event (patchset #15 id:280001 of https://codereview.chromium.org/1899823002/ )
Reason for revert:
After this CL, DumpAccessibilityEventsTest.AccessibilityEventsAriaComboBoxFocus started to fail consistently on the Mac 10.11 Tests bot.
https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/1737
Original issue's description:
> Uses the activedescendant_changed event received from Blink to fire the right focus event on the browser side.
>
> 1. Changed all <select> based widgets (list box role and menu list popup role) to fire activedescendant_changed events when the current selection changes. This behavior is the same as with ARIA combo boxes and other ARIA-based widgets that can have an active descendant. This means that we now have a uniform way of notifying the browser when the active child of a widget has changed.
> 2. Modified platform-specific code to fire the focus events on the active descendant when it changes, instead of relying on Blink.
> 3. Fires a focus event on the whole list or combo box when it collapses to make Windows screen readers enable their virtual cursor again.
> BUG= 593646
> R=dmazzoni@chromium.org
> TESTED=Jaws NVDA and VoiceOver, browser tests
>
> Committed: https://crrev.com/2c4ec4bed7e28e4f45efe742833dd3a154ac266b
> Cr-Commit-Position: refs/heads/master@{#396653}
TBR=dmazzoni@chromium.org,nektar@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 593646
Committed: https://crrev.com/292b41bbd603ae2f11d239f457a8a5f04387fa85
Cr-Commit-Position: refs/heads/master@{#396830}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+107 lines, -313 lines) |
Patch |
 |
M |
content/browser/accessibility/browser_accessibility.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/accessibility/browser_accessibility_manager.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/accessibility/browser_accessibility_manager.cc
|
View
|
|
3 chunks |
+20 lines, -33 lines |
0 comments
|
Download
|
 |
M |
content/browser/accessibility/browser_accessibility_manager_android.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/accessibility/browser_accessibility_manager_android.cc
|
View
|
|
1 chunk |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
M |
content/browser/accessibility/browser_accessibility_manager_mac.mm
|
View
|
|
3 chunks |
+19 lines, -14 lines |
0 comments
|
Download
|
 |
M |
content/browser/accessibility/browser_accessibility_manager_win.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/accessibility/browser_accessibility_manager_win.cc
|
View
|
|
2 chunks |
+0 lines, -6 lines |
0 comments
|
Download
|
 |
M |
content/browser/accessibility/browser_accessibility_win.cc
|
View
|
|
1 chunk |
+12 lines, -0 lines |
0 comments
|
Download
|
 |
M |
content/browser/accessibility/dump_accessibility_events_browsertest.cc
|
View
|
|
3 chunks |
+3 lines, -48 lines |
0 comments
|
Download
|
 |
D |
content/test/data/accessibility/event/aria-combo-box-collapse.html
|
View
|
|
1 chunk |
+0 lines, -23 lines |
0 comments
|
Download
|
 |
D |
content/test/data/accessibility/event/aria-combo-box-collapse-expected-mac.txt
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
D |
content/test/data/accessibility/event/aria-combo-box-collapse-expected-win.txt
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
D |
content/test/data/accessibility/event/aria-combo-box-expand.html
|
View
|
|
1 chunk |
+0 lines, -23 lines |
0 comments
|
Download
|
 |
D |
content/test/data/accessibility/event/aria-combo-box-expand-expected-mac.txt
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
D |
content/test/data/accessibility/event/aria-combo-box-expand-expected-win.txt
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
D |
content/test/data/accessibility/event/aria-combo-box-focus.html
|
View
|
|
1 chunk |
+0 lines, -20 lines |
0 comments
|
Download
|
 |
D |
content/test/data/accessibility/event/aria-combo-box-focus-expected-mac.txt
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
D |
content/test/data/accessibility/event/aria-combo-box-focus-expected-win.txt
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
D |
content/test/data/accessibility/event/aria-combo-box-next.html
|
View
|
|
1 chunk |
+0 lines, -22 lines |
0 comments
|
Download
|
 |
D |
content/test/data/accessibility/event/aria-combo-box-next-expected-mac.txt
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
D |
content/test/data/accessibility/event/aria-combo-box-next-expected-win.txt
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
content/test/data/accessibility/event/listbox-focus.html
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
content/test/data/accessibility/event/listbox-focus-expected-mac.txt
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
content/test/data/accessibility/event/listbox-focus-expected-win.txt
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
content/test/data/accessibility/event/listbox-next-expected-mac.txt
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
content/test/data/accessibility/event/listbox-next-expected-win.txt
|
View
|
|
1 chunk |
+5 lines, -4 lines |
0 comments
|
Download
|
 |
D |
content/test/data/accessibility/event/menulist-collapse.html
|
View
|
|
1 chunk |
+0 lines, -20 lines |
0 comments
|
Download
|
 |
D |
content/test/data/accessibility/event/menulist-collapse-expected-mac.txt
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
D |
content/test/data/accessibility/event/menulist-collapse-expected-win.txt
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
D |
content/test/data/accessibility/event/menulist-expand.html
|
View
|
|
1 chunk |
+0 lines, -22 lines |
0 comments
|
Download
|
 |
D |
content/test/data/accessibility/event/menulist-expand-expected-mac.txt
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
D |
content/test/data/accessibility/event/menulist-expand-expected-win.txt
|
View
|
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
 |
M |
content/test/data/accessibility/event/menulist-focus.html
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
content/test/data/accessibility/event/menulist-focus-expected-mac.txt
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
content/test/data/accessibility/event/menulist-focus-expected-win.txt
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
content/test/data/accessibility/event/menulist-next.html
|
View
|
|
1 chunk |
+1 line, -6 lines |
0 comments
|
Download
|
 |
M |
content/test/data/accessibility/event/menulist-next-expected-mac.txt
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
content/test/data/accessibility/event/menulist-next-expected-win.txt
|
View
|
|
1 chunk |
+5 lines, -6 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/accessibility/listbox-focus.html
|
View
|
|
2 chunks |
+7 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/accessibility/menu-list-open.html
|
View
|
|
1 chunk |
+4 lines, -11 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/accessibility/multiselect-list-reports-active-option-expected.txt
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXListBox.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXListBox.cpp
|
View
|
|
2 chunks |
+7 lines, -2 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.cpp
|
View
|
|
3 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXNodeObject.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/accessibility/AXObject.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
Total messages: 11 (5 generated)
|