content/browser/accessibility/browser_accessibility_manager_win.cc - Issue 2024053003: Revert of Uses the activedescendant_changed event received from Blink to fire the right focus event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_manager_win.cc

Issue 2024053003: Revert of Uses the activedescendant_changed event received from Blink to fire the right focus event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_manager_win.h ('k') | content/browser/accessibility/browser_accessibility_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_manager_win.cc

diff --git a/content/browser/accessibility/browser_accessibility_manager_win.cc b/content/browser/accessibility/browser_accessibility_manager_win.cc

index f5bf163e6e2b0a734cf4e7ef0b349c9b170bdae7..f09eea99cd42b1f9ae3ecdb3b0f1d2dcbe8e5c48 100644

--- a/content/browser/accessibility/browser_accessibility_manager_win.cc

+++ b/content/browser/accessibility/browser_accessibility_manager_win.cc

@@ -102,11 +102,6 @@

IA2_EVENT_DOCUMENT_RELOAD,

GetRoot()))->Fire();

}

-BrowserAccessibility* BrowserAccessibilityManagerWin::GetFocus() {

- BrowserAccessibility* focus = BrowserAccessibilityManager::GetFocus();

- return GetActiveDescendant(focus);

}

void BrowserAccessibilityManagerWin::NotifyAccessibilityEvent(

@@ -236,7 +231,6 @@

void BrowserAccessibilityManagerWin::FireFocusEvent(

BrowserAccessibilityEvent::Source source,

BrowserAccessibility* node) {

- DCHECK(node);

// On Windows, we always fire a FOCUS event on the root of a frame before

// firing a focus event within that frame.

if (node->manager() != last_focused_manager_ &&