Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2024033002:
Clear WorkerGlobalScope::m_thread in WorkerGlobalScope::dispose() (Closed)
|
Created:
4 years, 6 months ago by haraken Modified:
4 years, 6 months ago CC:
chromium-reviews, blink-reviews, kinuko+worker_chromium.org, falken, blink-worker-reviews_chromium.org, horo+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionClear WorkerGlobalScope::m_thread in WorkerGlobalScope::dispose()
WorkerGlobalScope::m_thread was intentionally not cleared due to destruction ordering issues in Oilpan (*),
but I think the issue had existed only in the transition period.
This CL adds code to clear WorkerGlobalScope::m_thread in WorkerGlobalScope::dispose().
(*) https://chromium.googlesource.com/chromium/src/+/58f0cf11c7e11bc0dcdd09c08912625b89ba97bb
BUG=
Committed: https://crrev.com/f8eb27561840ec6408c78749bd58a2b46fa13263
Cr-Commit-Position: refs/heads/master@{#398254}
Patch Set 1 #
Messages
Total messages: 18 (9 generated)
Description was changed from ========== Clear WorkerGlobalScope::m_thread in WorkerGlobalScope::dispose() BUG= ========== to ========== Clear WorkerGlobalScope::m_thread in WorkerGlobalScope::dispose() WorkerGlobalScope::m_thread was intentionally not cleared due to destruction ordering issues in Oilpan (*), but I think the issue had existed only in the transition period. This CL adds code to clear WorkerGlobalScope::m_thread in WorkerGlobalScope::dispose(). (*) https://chromium.googlesource.com/chromium/src/+/58f0cf11c7e11bc0dcdd09c08912... BUG= ==========
haraken@chromium.org changed reviewers: + oilpan-reviews@chromium.org, sigbjornf@opera.com
PTAL
lgtm - if it works out, good.
The CQ bit was checked by haraken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024033002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
The CQ bit was checked by haraken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024033002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
The CQ bit was checked by haraken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2024033002/1
Message was sent while issue was closed.
Description was changed from ========== Clear WorkerGlobalScope::m_thread in WorkerGlobalScope::dispose() WorkerGlobalScope::m_thread was intentionally not cleared due to destruction ordering issues in Oilpan (*), but I think the issue had existed only in the transition period. This CL adds code to clear WorkerGlobalScope::m_thread in WorkerGlobalScope::dispose(). (*) https://chromium.googlesource.com/chromium/src/+/58f0cf11c7e11bc0dcdd09c08912... BUG= ========== to ========== Clear WorkerGlobalScope::m_thread in WorkerGlobalScope::dispose() WorkerGlobalScope::m_thread was intentionally not cleared due to destruction ordering issues in Oilpan (*), but I think the issue had existed only in the transition period. This CL adds code to clear WorkerGlobalScope::m_thread in WorkerGlobalScope::dispose(). (*) https://chromium.googlesource.com/chromium/src/+/58f0cf11c7e11bc0dcdd09c08912... BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Clear WorkerGlobalScope::m_thread in WorkerGlobalScope::dispose() WorkerGlobalScope::m_thread was intentionally not cleared due to destruction ordering issues in Oilpan (*), but I think the issue had existed only in the transition period. This CL adds code to clear WorkerGlobalScope::m_thread in WorkerGlobalScope::dispose(). (*) https://chromium.googlesource.com/chromium/src/+/58f0cf11c7e11bc0dcdd09c08912... BUG= ========== to ========== Clear WorkerGlobalScope::m_thread in WorkerGlobalScope::dispose() WorkerGlobalScope::m_thread was intentionally not cleared due to destruction ordering issues in Oilpan (*), but I think the issue had existed only in the transition period. This CL adds code to clear WorkerGlobalScope::m_thread in WorkerGlobalScope::dispose(). (*) https://chromium.googlesource.com/chromium/src/+/58f0cf11c7e11bc0dcdd09c08912... BUG= Committed: https://crrev.com/f8eb27561840ec6408c78749bd58a2b46fa13263 Cr-Commit-Position: refs/heads/master@{#398254} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/f8eb27561840ec6408c78749bd58a2b46fa13263 Cr-Commit-Position: refs/heads/master@{#398254} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
