Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp

Issue 2024033002: Clear WorkerGlobalScope::m_thread in WorkerGlobalScope::dispose() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
diff --git a/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp b/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
index e1aff2aec72b87ffba4af9a81c36b36f0783a39a..b4596c1b9fffe2692d7cdd069c46210b7f82edae 100644
--- a/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
+++ b/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
@@ -210,16 +210,7 @@ void WorkerGlobalScope::dispose()
clearScript();
clearInspector();
m_eventQueue->close();
-
- // We do not clear the thread field of the
- // WorkerGlobalScope. Other objects keep the worker global scope
- // alive because they need its thread field to check that work is
- // being carried out on the right thread. We therefore cannot clear
- // the thread field before all references to the worker global
- // scope are gone.
- //
- // TODO(haraken): It's nasty to keep a raw pointer to WorkerThread
- // after disposing WorkerGlobalScope. m_thread should be cleared here.
+ m_thread = nullptr;
}
void WorkerGlobalScope::didEvaluateWorkerScript()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698