Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2023763013: Properly handle dialogClose message in password separated sign in flow. (Closed)

Created:
4 years, 6 months ago by anthonyvd
Modified:
4 years, 6 months ago
CC:
chromium-reviews, Moe
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Properly handle dialogClose message in password separated sign in flow. This fixes an issue where the flow would stay open when breaking to a full tab during SAML sign in flows. BUG=615062 TEST= 1. Enable #enable-password-separated-signin-flow in chrome://flags 2. Signin flow window properly closes after all sign ins 3. Signin flow window properly closes after entering SAML email and opening SAML provider's page in full tab. Committed: https://crrev.com/4650fea14f2e295f3176003ba3fff58926894e35 Cr-Commit-Position: refs/heads/master@{#397276}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M chrome/browser/ui/webui/signin/inline_login_handler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/signin/inline_login_handler.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/signin/inline_login_handler_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
anthonyvd
Hi Roger, can you please take a look at this small fix? +Moe fyi Thanks!
4 years, 6 months ago (2016-06-01 15:45:52 UTC) #2
Roger Tawa OOO till Jul 10th
lgtm
4 years, 6 months ago (2016-06-01 20:42:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023763013/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023763013/1
4 years, 6 months ago (2016-06-01 20:58:53 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-01 22:50:05 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-01 22:51:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4650fea14f2e295f3176003ba3fff58926894e35
Cr-Commit-Position: refs/heads/master@{#397276}

Powered by Google App Engine
This is Rietveld 408576698