chrome/browser/ui/webui/signin/inline_login_handler_impl.cc - Issue 2023763013: Properly handle dialogClose message in password separated sign in flow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

Issue 2023763013: Properly handle dialogClose message in password separated sign in flow. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

diff --git a/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc b/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

index 0b96abb2da2b76e38636cc4da8c584131192395b..e3e392c3c50e4d935fe12ffb0e4a0f8dcfd97c99 100644

--- a/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

+++ b/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc

@@ -853,8 +853,6 @@ void InlineLoginHandlerImpl::FinishCompleteLogin(

if (params.handler)

params.handler->

web_ui()->CallJavascriptFunction("inline.login.closeDialog");

- CloseModalSigninIfNeeded(params.handler);

}

void InlineLoginHandlerImpl::HandleLoginError(const std::string& error_msg) {

« no previous file with comments | « chrome/browser/ui/webui/signin/inline_login_handler.cc ('k') | no next file » | no next file with comments »