Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2023733002: service worker: Remove unused PROVIDER_FOR_SANDBOXED_IFRAME (Closed)

Created:
4 years, 6 months ago by falken
Modified:
4 years, 6 months ago
Reviewers:
horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

service worker: Remove unused PROVIDER_FOR_SANDBOXED_IFRAME Clean-up only. This was added in https://codereview.chromium.org/1191293002/ then became unused in https://codereview.chromium.org/1399363004. Originally it signaled to the ServiceWorkerNetworkProvider ctor that the provider id should be set to invalid; now the default ctor is used accomplish that. BUG= Committed: https://crrev.com/ae9107fb035320cc53558a0bb1ff5c9bf99cfffe Cr-Commit-Position: refs/heads/master@{#396685}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -18 lines) Patch
M content/browser/service_worker/service_worker_dispatcher_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_provider_host.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M content/child/service_worker/service_worker_network_provider.cc View 2 chunks +1 line, -10 lines 0 comments Download
M content/common/service_worker/service_worker_types.h View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
falken
ptal
4 years, 6 months ago (2016-05-30 03:38:39 UTC) #2
horo
lgtm
4 years, 6 months ago (2016-05-30 04:43:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023733002/1
4 years, 6 months ago (2016-05-30 04:44:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-30 06:33:12 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-30 06:35:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ae9107fb035320cc53558a0bb1ff5c9bf99cfffe
Cr-Commit-Position: refs/heads/master@{#396685}

Powered by Google App Engine
This is Rietveld 408576698