content/browser/service_worker/service_worker_provider_host.cc - Issue 2023733002: service worker: Remove unused PROVIDER_FOR_SANDBOXED_IFRAME

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_provider_host.cc

Issue 2023733002: service worker: Remove unused PROVIDER_FOR_SANDBOXED_IFRAME (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_dispatcher_host.cc ('k') | content/child/service_worker/service_worker_network_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_provider_host.cc

diff --git a/content/browser/service_worker/service_worker_provider_host.cc b/content/browser/service_worker/service_worker_provider_host.cc

index b02d789b9c612edd6b6ae041d13a2440a6dfa9db..21e0ddf6239ab50140f37c2ac4180f613cd2beca 100644

--- a/content/browser/service_worker/service_worker_provider_host.cc

+++ b/content/browser/service_worker/service_worker_provider_host.cc

@@ -74,7 +74,6 @@ ServiceWorkerProviderHost::ServiceWorkerProviderHost(

dispatcher_host_(dispatcher_host),

allow_association_(true) {

DCHECK_NE(SERVICE_WORKER_PROVIDER_UNKNOWN, provider_type_);

- DCHECK_NE(SERVICE_WORKER_PROVIDER_FOR_SANDBOXED_FRAME, provider_type_);

// PlzNavigate

CHECK(render_process_id != ChildProcessHost::kInvalidUniqueID ||

@@ -212,7 +211,6 @@ bool ServiceWorkerProviderHost::IsProviderForClient() const {

return true;

case SERVICE_WORKER_PROVIDER_FOR_CONTROLLER:

return false;

- case SERVICE_WORKER_PROVIDER_FOR_SANDBOXED_FRAME:

case SERVICE_WORKER_PROVIDER_UNKNOWN:

NOTREACHED() << provider_type_;

}

@@ -230,7 +228,6 @@ blink::WebServiceWorkerClientType ServiceWorkerProviderHost::client_type()

case SERVICE_WORKER_PROVIDER_FOR_SHARED_WORKER:

return blink::WebServiceWorkerClientTypeSharedWorker;

case SERVICE_WORKER_PROVIDER_FOR_CONTROLLER:

- case SERVICE_WORKER_PROVIDER_FOR_SANDBOXED_FRAME:

case SERVICE_WORKER_PROVIDER_UNKNOWN:

NOTREACHED() << provider_type_;

}