Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2023693003: Revert of Disable warning 4702: Unreachable code for the WPO/PGO builds. (Closed)

Created:
4 years, 6 months ago by Lei Zhang
Modified:
4 years, 6 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@handle_verifier
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable warning 4702: Unreachable code for the WPO/PGO builds. (patchset #2 id:40001 of https://codereview.chromium.org/2023653002/ ) Reason for revert: Broke DrMemory builders: gyp: Key 'conditions' repeated at level 5 with key path 'conditions.12.1.target_defaults' while reading C:\b\build\slave\drm-cr\build\src\build\common.gypi while reading includes of C:\b\build\slave\drm-cr\build\src\build\all.gyp Original issue's description: > Disable warning 4702: Unreachable code for the WPO/PGO builds. > > BUG=490934 > > Committed: https://crrev.com/04269068016b6ee7ac16c1d93c118668ac3a8936 > Cr-Commit-Position: refs/heads/master@{#396647} TBR=scottmg@chromium.org,sebmarchand@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=490934 Committed: https://crrev.com/7c271e2113631dee0fb917154d8ba5814d56e33b Cr-Commit-Position: refs/heads/master@{#396651}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -21 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -12 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Lei Zhang
Created Revert of Disable warning 4702: Unreachable code for the WPO/PGO builds.
4 years, 6 months ago (2016-05-29 00:38:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023693003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023693003/1
4 years, 6 months ago (2016-05-29 00:38:38 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-29 00:39:08 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-05-29 00:41:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c271e2113631dee0fb917154d8ba5814d56e33b
Cr-Commit-Position: refs/heads/master@{#396651}

Powered by Google App Engine
This is Rietveld 408576698