Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Unified Diff: build/common.gypi

Issue 2023693003: Revert of Disable warning 4702: Unreachable code for the WPO/PGO builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@handle_verifier
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index f6c4cd0df21b4ebc9eeaee0dfc2158bd8c659b57..989fb18c08502491d42ed6accbfddab6defe8b83 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -5653,18 +5653,6 @@
# See http://bugs.icu-project.org/trac/ticket/11122
4595,
],
- 'conditions': [
- ['full_wpo_on_official==1', {
- # Disable Warning 4702 ("Unreachable code") for the WPO/PGO
- # builds. Probably anything that this would catch that
- # wouldn't be caught in a normal build isn't going to
- # actually be a bug, so the incremental value of C4702 for
- # PGO builds is likely very small.
- 'msvs_disabled_warnings': [
- 4702
- ],
- }],
- ],
'msvs_settings': {
'VCCLCompilerTool': {
'AdditionalOptions': ['/MP'],
« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698