build/common.gypi - Issue 2023693003: Revert of Disable warning 4702: Unreachable code for the WPO/PGO builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 2023693003: Revert of Disable warning 4702: Unreachable code for the WPO/PGO builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@handle_verifier

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index f6c4cd0df21b4ebc9eeaee0dfc2158bd8c659b57..989fb18c08502491d42ed6accbfddab6defe8b83 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -5653,18 +5653,6 @@

# See http://bugs.icu-project.org/trac/ticket/11122

4595,

- 'conditions': [

- ['full_wpo_on_official==1', {

- # Disable Warning 4702 ("Unreachable code") for the WPO/PGO

- # builds. Probably anything that this would catch that

- # wouldn't be caught in a normal build isn't going to

- # actually be a bug, so the incremental value of C4702 for

- # PGO builds is likely very small.

- 'msvs_disabled_warnings': [

- 4702

- ],

- }],

- ],

'msvs_settings': {

'VCCLCompilerTool': {

'AdditionalOptions': ['/MP'],

« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »