Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2023633002: Change PopDataAsValue to return a std::unique_ptr. (Closed)

Created:
4 years, 6 months ago by dcheng
Modified:
4 years, 6 months ago
Reviewers:
hashimoto, satorux1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change PopDataAsValue to return a std::unique_ptr. BUG=581865 Committed: https://crrev.com/cef03546ac3c2e668b6c7686ea9a23f87f183136 Cr-Commit-Position: refs/heads/master@{#396686}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -66 lines) Patch
M chromeos/dbus/shill_client_unittest_base.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M dbus/values_util.h View 2 chunks +4 lines, -1 line 0 comments Download
M dbus/values_util.cc View 9 chunks +27 lines, -22 lines 0 comments Download
M dbus/values_util_unittest.cc View 12 chunks +42 lines, -42 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dcheng
4 years, 6 months ago (2016-05-29 23:06:22 UTC) #2
dcheng
+hashimoto, mind reviewing the overall patch? I will TBR the trivial compile fix in //chromeos ...
4 years, 6 months ago (2016-05-30 01:26:07 UTC) #4
hashimoto
lgtm For what do you need to TBR satorux? At least, you don't need it ...
4 years, 6 months ago (2016-05-30 04:27:18 UTC) #5
dcheng
Oh, that makes things easier. I missed the separate OWNERS in //chromeos/dbus. Thanks!
4 years, 6 months ago (2016-05-30 05:48:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023633002/20001
4 years, 6 months ago (2016-05-30 05:48:41 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-30 06:34:09 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-05-30 06:36:55 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cef03546ac3c2e668b6c7686ea9a23f87f183136
Cr-Commit-Position: refs/heads/master@{#396686}

Powered by Google App Engine
This is Rietveld 408576698