chromeos/dbus/shill_client_unittest_base.cc - Issue 2023633002: Change PopDataAsValue to return a std::unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/shill_client_unittest_base.cc

Issue 2023633002: Change PopDataAsValue to return a std::unique_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/dbus/shill_client_unittest_base.cc

diff --git a/chromeos/dbus/shill_client_unittest_base.cc b/chromeos/dbus/shill_client_unittest_base.cc

index 44c7961f9ddf953e8fa55714aa88a0477b7c4974..35b9d7041d5edd350c2a824ceabca34923a5925d 100644

--- a/chromeos/dbus/shill_client_unittest_base.cc

+++ b/chromeos/dbus/shill_client_unittest_base.cc

@@ -325,7 +325,7 @@ void ShillClientUnittestBase::ExpectDictionaryValueArgument(

case dbus::Message::BOOL:

case dbus::Message::INT32:

case dbus::Message::STRING:

- value.reset(dbus::PopDataAsValue(&variant_reader));

+ value = dbus::PopDataAsValue(&variant_reader);

break;

default:

NOTREACHED();

« no previous file with comments | « no previous file | dbus/values_util.h » ('j') | no next file with comments »