third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h - Issue 2023603003: Fix content scripts that use WebGL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

Issue 2023603003: Fix content scripts that use WebGL. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@yukishiino-v8privateproperty-fix

Patch Set: Reintroduced persistent caches. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp ('k') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

index f6738b88b58248e6ae101cf6b1e65dac499bdb38..90b813faeb512a9b6e7602db4ae76dc6048ec050 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

@@ -31,6 +31,7 @@

#include "bindings/core/v8/ScriptState.h"

#include "bindings/core/v8/ScriptValue.h"

#include "bindings/core/v8/ScriptWrappable.h"

+#include "bindings/core/v8/V8PrivateProperty.h"

#include "core/CoreExport.h"

#include "core/dom/DOMTypedArray.h"

#include "core/dom/TypedFlexibleArrayBufferView.h"

@@ -1036,10 +1037,7 @@ protected:

virtual void renderbufferStorageImpl(GLenum target, GLsizei samples, GLenum internalformat, GLsizei width, GLsizei height, const char* functionName);

- // Ensures that the JavaScript wrappers for objects that are

- // latched into the context's state, or which are implicitly

- // linked together (like programs and their attached shaders), are

- // not garbage collected before they should be.

+ // For optimization purposes when in the main world.

ScopedPersistent<v8::Array> m_2DTextureWrappers;

ScopedPersistent<v8::Array> m_2DArrayTextureWrappers;

ScopedPersistent<v8::Array> m_3DTextureWrappers;

@@ -1061,7 +1059,7 @@ protected:

};

ScopedPersistent<v8::Array> m_miscWrappers;

- static void preserveObjectWrapper(ScriptState*, ScriptWrappable* sourceObject, v8::Local<v8::String> hiddenValueName, ScopedPersistent<v8::Array>* persistentCache, uint32_t index, ScriptWrappable* targetObject);

+ static void preserveObjectWrapper(ScriptState*, ScriptWrappable* sourceObject, const V8PrivateProperty::Symbol& privateSymbol, ScopedPersistent<v8::Array>* persistentCache, uint32_t index, ScriptWrappable* targetObject);

// Called to lazily instantiate the wrapper for the default VAO

// during calls to bindBuffer and vertexAttribPointer (from