Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2023483003: DevTools: empty user agent validation (Closed)

Created:
4 years, 6 months ago by luoe
Modified:
4 years, 6 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: empty user agent validation The red invalid outline should make it clear that an empty custom UA string should not be allowed. BUG=615461 Committed: https://crrev.com/78c0c5d499f1bbf5486b77fd15df03b39b5adf8b Cr-Commit-Position: refs/heads/master@{#396878}

Patch Set 1 #

Patch Set 2 : Updated string from feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/networkConfigView.css View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
luoe
The red invalid outline should make it clear that an empty custom UA string should ...
4 years, 6 months ago (2016-05-27 21:12:58 UTC) #2
lushnikov
lgtm
4 years, 6 months ago (2016-05-27 21:21:03 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023483003/1
4 years, 6 months ago (2016-05-27 21:23:24 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-27 23:17:29 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023483003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023483003/20001
4 years, 6 months ago (2016-05-27 23:26:45 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-28 01:20:24 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2023483003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2023483003/20001
4 years, 6 months ago (2016-05-31 17:00:08 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-31 18:51:07 UTC) #18
commit-bot: I haz the power
4 years, 6 months ago (2016-05-31 18:52:20 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/78c0c5d499f1bbf5486b77fd15df03b39b5adf8b
Cr-Commit-Position: refs/heads/master@{#396878}

Powered by Google App Engine
This is Rietveld 408576698