third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js - Issue 2023483003: DevTools: empty user agent validation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js

Issue 2023483003: DevTools: empty user agent validation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated string from feedback Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js

index 2a8e5e6c8643a67ab0bad3c84b475c2afa8693e5..43f27977dcae2f489b7b6c9325a9c7fbaf3e1d0d 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkConfigView.js

@@ -111,6 +111,8 @@ WebInspector.NetworkConfigView.createUserAgentSelectAndInput = function()

otherUserAgentElement.type = "text";

otherUserAgentElement.value = userAgentSetting.get();

otherUserAgentElement.title = userAgentSetting.get();

+ otherUserAgentElement.placeholder = WebInspector.UIString("Enter a custom user agent");

+ otherUserAgentElement.required = true;

settingChanged();

userAgentSelectElement.addEventListener("change", userAgentSelected, false);

« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/network/networkConfigView.css » ('j') | no next file with comments »