content/browser/web_contents/web_contents_impl.cc - Issue 2023453003: Make RenderFrameHostImpl::GetRenderWidgetHost() always return an object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 2023453003: Make RenderFrameHostImpl::GetRenderWidgetHost() always return an object (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing creis' comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index 678611e573f7695c029785af02986e4094e34319..640fe73b2af0ad13e59e6645a1560469a86cac16 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -2366,7 +2366,7 @@ void WebContentsImpl::OnMoveValidationMessage(

void WebContentsImpl::SendScreenRects() {

for (FrameTreeNode* node : frame_tree_.Nodes()) {

- if (node->current_frame_host()->GetRenderWidgetHost())

+ if (node->current_frame_host()->is_local_root())

node->current_frame_host()->GetRenderWidgetHost()->SendScreenRects();

}

« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.cc ('k') | no next file » | no next file with comments »