Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Side by Side Diff: content/browser/web_contents/web_contents_impl.cc

Issue 2023453003: Make RenderFrameHostImpl::GetRenderWidgetHost() always return an object (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing creis' comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/web_contents/web_contents_impl.h" 5 #include "content/browser/web_contents/web_contents_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <cmath> 9 #include <cmath>
10 #include <utility> 10 #include <utility>
(...skipping 2348 matching lines...) Expand 10 before | Expand all | Expand 10 after
2359 } 2359 }
2360 2360
2361 void WebContentsImpl::OnMoveValidationMessage( 2361 void WebContentsImpl::OnMoveValidationMessage(
2362 const gfx::Rect& anchor_in_root_view) { 2362 const gfx::Rect& anchor_in_root_view) {
2363 if (delegate_) 2363 if (delegate_)
2364 delegate_->MoveValidationMessage(this, anchor_in_root_view); 2364 delegate_->MoveValidationMessage(this, anchor_in_root_view);
2365 } 2365 }
2366 2366
2367 void WebContentsImpl::SendScreenRects() { 2367 void WebContentsImpl::SendScreenRects() {
2368 for (FrameTreeNode* node : frame_tree_.Nodes()) { 2368 for (FrameTreeNode* node : frame_tree_.Nodes()) {
2369 if (node->current_frame_host()->GetRenderWidgetHost()) 2369 if (node->current_frame_host()->is_local_root())
2370 node->current_frame_host()->GetRenderWidgetHost()->SendScreenRects(); 2370 node->current_frame_host()->GetRenderWidgetHost()->SendScreenRects();
2371 } 2371 }
2372 2372
2373 RenderWidgetHostViewBase* rwhv = 2373 RenderWidgetHostViewBase* rwhv =
2374 static_cast<RenderWidgetHostViewBase*>(GetRenderWidgetHostView()); 2374 static_cast<RenderWidgetHostViewBase*>(GetRenderWidgetHostView());
2375 if (rwhv) { 2375 if (rwhv) {
2376 SendPageMessage(new PageMsg_UpdateWindowScreenRect( 2376 SendPageMessage(new PageMsg_UpdateWindowScreenRect(
2377 MSG_ROUTING_NONE, rwhv->GetBoundsInRootWindow())); 2377 MSG_ROUTING_NONE, rwhv->GetBoundsInRootWindow()));
2378 } 2378 }
2379 2379
(...skipping 2685 matching lines...) Expand 10 before | Expand all | Expand 10 after
5065 for (RenderViewHost* render_view_host : render_view_host_set) 5065 for (RenderViewHost* render_view_host : render_view_host_set)
5066 render_view_host->OnWebkitPreferencesChanged(); 5066 render_view_host->OnWebkitPreferencesChanged();
5067 } 5067 }
5068 5068
5069 void WebContentsImpl::SetJavaScriptDialogManagerForTesting( 5069 void WebContentsImpl::SetJavaScriptDialogManagerForTesting(
5070 JavaScriptDialogManager* dialog_manager) { 5070 JavaScriptDialogManager* dialog_manager) {
5071 dialog_manager_ = dialog_manager; 5071 dialog_manager_ = dialog_manager;
5072 } 5072 }
5073 5073
5074 } // namespace content 5074 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698