Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: content/browser/accessibility/dump_accessibility_browsertest_base.cc

Issue 2023453003: Make RenderFrameHostImpl::GetRenderWidgetHost() always return an object (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Need a cast in test Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/dump_accessibility_browsertest_base.cc
diff --git a/content/browser/accessibility/dump_accessibility_browsertest_base.cc b/content/browser/accessibility/dump_accessibility_browsertest_base.cc
index 0c09681752226a2b0bb249d9d5c6e58acba5a8d1..f1e007fbc4136f23f228f1c8ae578b87f00fefdb 100644
--- a/content/browser/accessibility/dump_accessibility_browsertest_base.cc
+++ b/content/browser/accessibility/dump_accessibility_browsertest_base.cc
@@ -269,10 +269,8 @@ void DumpAccessibilityTestBase::RunTestForPlatform(
RenderFrameHostImpl* current_frame_host = node->current_frame_host();
if (!current_frame_host)
continue;
- RenderWidgetHostImpl* rwh = current_frame_host->GetRenderWidgetHost();
- if (!rwh)
- continue;
- RenderWidgetHostViewBase* rwhv = rwh->GetView();
+ RenderWidgetHostViewBase* rwhv =
+ static_cast<RenderWidgetHostViewBase*>(current_frame_host->GetView());
Charlie Reis 2016/05/27 22:50:28 Sanity check: Before, this code skipped frames tha
kenrb 2016/05/30 19:39:53 Good point, fixed it to match the old behavior.
if (rwhv && rwhv->IsChildFrameForTesting()) {
SurfaceHitTestReadyNotifier notifier(
static_cast<RenderWidgetHostViewChildFrame*>(rwhv));

Powered by Google App Engine
This is Rietveld 408576698