content/browser/frame_host/cross_process_frame_connector.cc - Issue 2023453003: Make RenderFrameHostImpl::GetRenderWidgetHost() always return an object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/cross_process_frame_connector.cc

Issue 2023453003: Make RenderFrameHostImpl::GetRenderWidgetHost() always return an object (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Need a cast in test Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/accessibility/dump_accessibility_browsertest_base.cc ('K') | « content/browser/browser_plugin/browser_plugin_guest.cc ('k') | content/browser/frame_host/render_frame_host_impl.h » ('j') | content/browser/frame_host/render_frame_host_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/cross_process_frame_connector.cc

diff --git a/content/browser/frame_host/cross_process_frame_connector.cc b/content/browser/frame_host/cross_process_frame_connector.cc

index 6002fcaa6b18e3707e4430c4cdf62f085f4adbc6..0cf82dde6de18a5b8431bc176c4287d2edf49fd0 100644

--- a/content/browser/frame_host/cross_process_frame_connector.cc

+++ b/content/browser/frame_host/cross_process_frame_connector.cc

@@ -286,8 +286,7 @@ void CrossProcessFrameConnector::SetRect(const gfx::Rect& frame_rect) {

old_rect.y() != child_frame_rect_.y()) {

for (FrameTreeNode* node :

proxy_node->frame_tree()->SubtreeNodes(proxy_node)) {

- if (node != proxy_node &&

- node->current_frame_host()->GetRenderWidgetHost())

+ if (node != proxy_node && node->current_frame_host()->IsLocalRoot())

node->current_frame_host()->GetRenderWidgetHost()->SendScreenRects();

}