Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: components/offline_pages/offline_page_model.h

Issue 2023293002: OfflinePageModel cleanups - improved CanSavePage() and moved static kInvalidOfflineId to impl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: synced Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_model.h
diff --git a/components/offline_pages/offline_page_model.h b/components/offline_pages/offline_page_model.h
index 29107e0ac8135d1672cea86259277206246fe1a6..cb94a5a9b2efb9cb97114ad5a0f4e40e55c30e67 100644
--- a/components/offline_pages/offline_page_model.h
+++ b/components/offline_pages/offline_page_model.h
@@ -25,7 +25,6 @@ class Time;
namespace offline_pages {
static const char* const kBookmarkNamespace = "bookmark";
-static const int64_t kInvalidOfflineId = 0;
struct ClientId;
struct OfflinePageItem;
@@ -79,9 +78,8 @@ class OfflinePageModel : public base::SupportsUserData,
using DeletePageResult = offline_pages::DeletePageResult;
using SavePageResult = offline_pages::SavePageResult;
- // Returns true if an offline copy can be saved for the given URL.
- // TODO(dougarnett): Consider renaming and moving to Utils.
- static bool CanSavePage(const GURL& url);
+ // Returns true if saving an offline page may be attempted for |url|.
+ static bool CanSaveURL(const GURL& url);
OfflinePageModel();
~OfflinePageModel() override;
« no previous file with comments | « chrome/browser/android/offline_pages/recent_tab_helper.cc ('k') | components/offline_pages/offline_page_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698