OfflinePageModel cleanups - improved CanSavePage() and moved static kInvalidOfflineId to impl

components/offline_pages/offline_page_model.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OFFLINE_PAGES_OFFLINE_PAGE_MODEL_H_
 #define COMPONENTS_OFFLINE_PAGES_OFFLINE_PAGE_MODEL_H_
 
 #include <stdint.h>
 
 #include <memory>
 #include <set>
 #include <string>
 #include <vector>
 
 #include "base/supports_user_data.h"
 #include "components/offline_pages/offline_page_archiver.h"
 #include "components/offline_pages/offline_page_storage_manager.h"
 #include "components/offline_pages/offline_page_types.h"
 
 class GURL;
 namespace base {
 class Time;
 }  // namespace base
 
 namespace offline_pages {
 
 static const char* const kBookmarkNamespace = "bookmark";
-static const int64_t kInvalidOfflineId = 0;
 
 struct ClientId;
 struct OfflinePageItem;
 
 // Service for saving pages offline, storing the offline copy and metadata, and
 // retrieving them upon request.
 //
 // Example usage:
 //   class ArchiverImpl : public OfflinePageArchiver {
 //     // This is a class that knows how to create archiver
@@ skipping 33 matching lines @@
 
   using CheckPagesExistOfflineResult =
       offline_pages::CheckPagesExistOfflineResult;
   using MultipleOfflinePageItemResult =
       offline_pages::MultipleOfflinePageItemResult;
   using SingleOfflinePageItemResult =
       offline_pages::SingleOfflinePageItemResult;
   using DeletePageResult = offline_pages::DeletePageResult;
   using SavePageResult = offline_pages::SavePageResult;
 
-  // Returns true if an offline copy can be saved for the given URL.
-  // TODO(dougarnett): Consider renaming and moving to Utils.
-  static bool CanSavePage(const GURL& url);
+  // Returns true if saving an offline page may be attempted for |url|.
+  static bool CanSaveURL(const GURL& url);
 
   OfflinePageModel();
   ~OfflinePageModel() override;
 
   virtual void AddObserver(Observer* observer) = 0;
   virtual void RemoveObserver(Observer* observer) = 0;
 
   // Attempts to save a page addressed by |url| offline. Requires that the model
   // is loaded.  Generates a new offline id and returns it.
   virtual void SavePage(const GURL& url,
@@ skipping 95 matching lines @@
   // Returns the policy controller.
   virtual ClientPolicyController* GetPolicyController() = 0;
 
   // TODO(dougarnett): Remove this and its uses.
   virtual bool is_loaded() const = 0;
 };
 
 }  // namespace offline_pages
 
 #endif  // COMPONENTS_OFFLINE_PAGES_OFFLINE_PAGE_MODEL_H_